fix(sidebar): keep peeked sidebar open while the task Filter menu is open#3666
Merged
charlesvien merged 4 commits intoJul 22, 2026
Merged
Conversation
…open With hover-peek active, opening the tasks-header Filter dropdown and then moving the pointer off the panel collapsed the sidebar while the menu (rendered in a portal anchored to its trigger) stayed open, leaving it floating over the content, chasing its vanished anchor. Apply the same hold used by the ProjectSwitcher (PostHog#3484): TaskFilterMenu holds the sidebar peek on open and releases it on close (and on unmount), so the peek stays until the menu closes. Hover behaviour is unchanged when no menu is open. Generated-By: PostHog Code Task-Id: 1252280f-2bb1-49bc-9f6a-fe86f670957e
|
😎 This pull request was merged. |
Member
|
Thanks for this @aleexzxzxzx! |
Contributor
Author
|
@charlesvien happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With sidebar hover-peek active, opening the tasks-header Filter dropdown and then moving the pointer off the panel collapsed the sidebar while the menu (rendered in a portal anchored to its trigger) stayed open, leaving it floating over the content, chasing its vanished anchor.
Same failure mode as #3483, but for the task Filter menu instead of the ProjectSwitcher.
Closes #3665
Changes
TaskFilterMenunow holds the sidebar peek on open and releases it on close (and on unmount), reusingholdSidebarPeek/releaseSidebarPeekfrom fix(sidebar): keep the peeked sidebar open while the ProjectSwitcher menu is open #3484.Before / after
video.mp4
How did you test this?
pnpm --filter @posthog/ui typecheck