feat(canvas): keep task threads human-only#3660
Draft
raquelmsmith wants to merge 1 commit into
Draft
Conversation
Stop mirroring the agent's live conversation into the task thread panel. Threads now show human discussion only; the agent's turns, prompt echoes, and status line no longer post into the thread. Removes the live-session wiring in the panel that also pinned an agent process alive purely to feed the thread. The human @agent forward action is unchanged. Generated-By: PostHog Code Task-Id: 8261c40f-2fbf-4334-a4e7-e61bf1c332fc
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Task threads had become noisy: the agent's live conversation (its turns, the prompts sent to it, and a running status line) was mirrored into the thread panel alongside human comments. This broke the thread as a focused space for human↔human discussion. Raised in a Slack thread by the canvas/channels users.
Changes
useSessionViewState/useSessionConnection/useConversationItems) that was subscribing to the agent session purely to feed the thread — this also stops pinning an agent process alive just for the panel.buildThreadTimelineto a single human-message row kind and dropped the now-unused agent-turn/status helpers.@agentforward action (task author sending a thread message to the agent) is unchanged, as are backend-authored announcement rows.How did you test this?
pnpm --filter @posthog/core --filter @posthog/ui typecheck— clean.pnpm --filter @posthog/core exec vitest run src/canvas/threadTimeline.test.ts— pass.pnpm --filter @posthog/ui exec vitest run src/features/canvas/components/ThreadPanel.test.tsx— pass.biome checkon the changed files — clean.Automatic notifications
Created with PostHog from a Slack thread