Skip to content

refactor(mobile): reuse transport and permission policies#3635

Open
richardsolomou wants to merge 6 commits into
posthog-code/share-mobile-inbox-transportfrom
posthog-code/share-mobile-mcp-skill-transport
Open

refactor(mobile): reuse transport and permission policies#3635
richardsolomou wants to merge 6 commits into
posthog-code/share-mobile-inbox-transportfrom
posthog-code/share-mobile-mcp-skill-transport

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 21, 2026

Copy link
Copy Markdown
Member

Problem

Mobile duplicated MCP and skill-store HTTP clients, while UI and mobile independently interpreted permission options, plan approvals, and recoverable pending prompts.

Depends on #3634
Refs #2416

Changes

I switched mobile MCP/skill consumers to the existing PostHogAPIClient. Shared permission, plan, and pending-prompt decisions now live in core and are consumed by both UI and mobile; each surface keeps its own rendering.

How did you test this?

  • Ran 2,576 core tests and the core typecheck.
  • Ran 129 API-client tests, 1,832 UI tests, and 411 mobile tests.
  • Ran desktop and web typechecks, Biome, and the host-boundary check.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 5bb5175.

@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared MCP and skill transport refactor(mobile): reuse shared transport and recovery logic Jul 21, 2026
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared transport and recovery logic refactor(mobile): reuse shared transport and presentation logic Jul 21, 2026
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared transport and presentation logic refactor(mobile): reuse shared transport and permission logic Jul 21, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from fcec203 to 407d084 Compare July 23, 2026 13:06
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from a5ab234 to d85caff Compare July 23, 2026 13:08
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared transport and permission logic refactor(mobile): reuse transport and permission policies Jul 23, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 407d084 to e340cac Compare July 23, 2026 13:36
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from d85caff to 872c4ca Compare July 23, 2026 13:37
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Merge posthog-code/share-mobile-inbox-tr..." | Re-trigger Greptile

@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from dab3bbc to 29378f7 Compare July 23, 2026 16:34
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch 2 times, most recently from 6aa93d5 to eb313ca Compare July 23, 2026 17:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 29378f7 to 9d2bd25 Compare July 23, 2026 17:28
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
richardsolomou and others added 4 commits July 23, 2026 21:47
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-mcp-skill-transport branch from eb313ca to 5bb5175 Compare July 23, 2026 18:55
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-inbox-transport branch from 9d2bd25 to 408b0a2 Compare July 23, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant