fix(canvas): show only team messages in thread sidebar on full task view#3593
Closed
adboio wants to merge 1 commit into
Closed
fix(canvas): show only team messages in thread sidebar on full task view#3593adboio wants to merge 1 commit into
adboio wants to merge 1 commit into
Conversation
The channel task detail route renders the thread sidebar next to TaskDetail, which already hosts the agent session. The sidebar's timeline interleaved agent turns and user→agent prompts with the team conversation, so expanding a task from the channel-home thread left the same agent comms duplicated in both panes. Add a showAgentComms prop (default true) to ThreadPanel/ThreadSidebar that drops agent turns and prompts from the timeline and hides the agent status line. The full task view passes false, so its sidebar shows only the human-to-human thread. The channel-home sidebar is unchanged. Generated-By: PostHog Code Task-Id: c44f7e31-52a1-404e-8eda-0d21860bf272
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the full task view (
/website/$channelId/tasks/$taskId), the right-hand thread sidebar is rendered next toTaskDetail, which already hosts the agent session. The sidebar's timeline interleaved agent turns and user→agent prompts with the team conversation, so expanding a task from the channel-home thread left the same agent comms duplicated across both panes — the sidebar should show only the human-to-human conversation.Changes
showAgentCommsprop (defaulttrue) toThreadPanel/ThreadSidebar. Whenfalse, it drops agent turns and user→agent prompts from the timeline and hides the agent status line.showAgentComms={false}, so its sidebar shows only team messages.How did you test this?
pnpm --filter @posthog/ui typecheck— no new errors in the touched files (remaining errors are pre-existing missing-host-module resolution unrelated to this change).vitest runforthreadPanelStore.test.tsandWebsiteLayout.test.tsx— pass.biome checkon the three changed files — clean.Why
You end up with the full-screen task open and the same agent conversation duplicated in the thread sidebar; the sidebar should carry the team discussion only, since the agent session already lives in the main task pane.
Created with PostHog Code