Add missing store link metadata

[offalynne]

Store links for all non-RTR ports

[tabreturn]

Thanks for submitting this, @offalynne. However, there are several errors --

[96](https://github.com/PortsMaster/PortMaster-New/actions/runs/21803537283/job/62926486912?pr=2286#step:3:3297)
Error: blossomtales2: Unable to load ports/blossomtales2/port.json: Expecting value: line 33 column 5 (char 1223)
Error: firework: Unable to load ports/firework/port.json: Expecting property name enclosed in double quotes: line 30 column 7 (char 749)
Error: half-life: Unable to load ports/half-life/port.json: Expecting value: line 33 column 9 (char 1225)
Error: iortcw: Unable to load ports/iortcw/port.json: Expecting value: line 34 column 9 (char 1057)
Error: jubilee: Unable to load ports/jubilee/port.json: Expecting property name enclosed in double quotes: line 30 column 7 (char 769)
Warning: missiledancer: port_info['attr']['genres'] contains bad genre shump
Warning: yellowjacket: port_info['attr']['genres'] contains bad genre shump

You can run a check on your PC before submitting to catch and fix this kind of stuff :)
See: https://portmaster.games/packaging.html#creating-a-pull-request

[offalynne]

@tabreturn thank you for the review ! I have submitted changes to clear the errors this PR introduced.

The following are not a product of my changes as this data is untouched by my commits

Warning: missiledancer: port_info['attr']['genres'] contains bad genre shump
Warning: yellowjacket: port_info['attr']['genres'] contains bad genre shump

I can append to this PR to fix these warnings, but perhaps a separate PR is in order ?

[tabreturn]

@tabreturn #2287

Sorry -- checks have failed again. This won't merge. It seems you'll have to fix the shump errors. Not sure why you're getting this -- maybe you need to clone a fresh fork and apply your changes to it.

[bmdhacks]

Note this was attempted earlier but never shipped because it would force rebuild/redownload of all ports and kill our bandwidth (and people's handhelds).

#1469

[offalynne]

it would force rebuild/redownload of all ports

does not seem correct to be forever stuck with bad/out of date metadata because any change forces rebuild. if this is in fact the case (i have not confirmed it is) perhaps the workflow should change so as not to rebuild if version number is unchanged?

[bmdhacks]

it would force rebuild/redownload of all ports

does not seem correct to be forever stuck with bad/out of date metadata because any change forces rebuild. if this is in fact the case (i have not confirmed it is) perhaps the workflow should change so as not to rebuild if version number is unchanged?

Yes, that's the blocking change for these improvements. I believe klops has that implemented, I'm not sure, but yes it's what we need to do first. Nobody is suggesting we stagnate at the current behavior.

[offalynne]

@kloptops

[kloptops]

Yeah i have an idea of what i need to do, but haven't figured out the logic to do it.

Mental bandwidth is low at the moment. 😓

[offalynne]

Is it possible to have maintainer assistance to get this merge done?

I am deeply frustrated by the low quality of metadata which makes it more difficult to externally find & purchase the games required to use PortMaster than it reasonably should be.

Moreso when realizing this has already been attempted and both efforts are apparently gone to waste #1469

As further changes are made conflicts pile up and my confidence this will ever actually be addressed diminishes.

[bmdhacks]

We've explained the blocker: ports are rebuilt and redownloaded on metadata changes, possibly blowing up our quota. You are not entitled to other peoples time in open source unfortunately, so your options are:

1. Hire somebody to fix the issue of port.zip tied to metadata.
2. Do a one time donation to portmaster to upgrade our serving quotas and take the hit of committing this. (I would prefer we commit my version though)
3. Do the coding work yourself to fix the blocker.

We can all sit around and complain that too many people submit ports and nobody works on PM infrastructire besides klops, but the only real lever you have is to fix it yourself in some fashion.

[offalynne]

I would prefer we commit my version

👍