Skip to content

Issue #35 - implemented missing Int32_to_Int24_Dither function#798

Draft
whyismynamerudy wants to merge 6 commits intoPortAudio:masterfrom
whyismynamerudy:Issue-35-Conversion-Functions
Draft

Issue #35 - implemented missing Int32_to_Int24_Dither function#798
whyismynamerudy wants to merge 6 commits intoPortAudio:masterfrom
whyismynamerudy:Issue-35-Conversion-Functions

Conversation

@whyismynamerudy
Copy link

Title. Implemented the missing function "Int32_To_Int24_Dither" in "pa_converters.c" using the specified coding guidelines.

I had a few questions:

  1. Is doing conversions differently for Little Endian vs Big Endian machines required for all conversion functions? I noticed that some functions did make the distinction while some did not, and I cannot figure out why that is the case.
  2. What is the purpose of the sourceStride and the destinationStride variables in the conversion functions? Based off of how the other functions were implemented I gather that they're used for navigating across the bits of the binary numbers (I think?) but I am not sure. If that is the case, then why is it so that some strides are directly added onto src while others (such as the sourceStride in the function Int24_To_Float32) are multiplied by a certain number before adding them onto src?

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P4 Priority: Low src-common Common sources in /src/common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants