Skip to content

build: update compatible runtime dependencies - #1284

Merged
danieliser merged 4 commits into
developfrom
agent/runtime-dependencies-current
Aug 6, 2026
Merged

build: update compatible runtime dependencies#1284
danieliser merged 4 commits into
developfrom
agent/runtime-dependencies-current

Conversation

@danieliser

@danieliser danieliser commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

  • update @medv/finder from 3.2.0 to 4.0.2
  • update react-router-dom from 7.18.0 to 7.18.2
  • remove the obsolete @types/react-router-dom package because React Router ships its own types

Validation

  • pnpm install --frozen-lockfile
  • pnpm run test:unit — 28 suites / 383 tests passed
  • pnpm run build:production
  • TypeScript builds for @popup-maker/admin-bar, @popup-maker/cta-admin, and their workspace dependencies
  • git diff --check

Intentionally deferred

iframe-resizer 5.5.9 now advertises GPL-3.0 for non-commercial use and requires a paid license for commercial use. This PR keeps the current 4.4.5 release to avoid introducing a licensing obligation without approval.

Summary by CodeRabbit

  • Chores
    • Updated routing components to a newer version for improved compatibility and stability.
    • Upgraded the element-finder utility used by the admin bar.
    • Removed an outdated routing type package that is no longer needed.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 06b56205-bf69-49f5-8bcd-1c5847b8fc03

📥 Commits

Reviewing files that changed from the base of the PR and between 9f71859 and 41da9a1.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • package.json
  • packages/admin-bar/package.json
  • packages/cta-admin/package.json

Walkthrough

The pull request updates react-router-dom to 7.18.2, updates @medv/finder to ^4.0.2, and removes the obsolete @types/react-router-dom development dependency.

Changes

Dependency updates

Layer / File(s) Summary
React Router dependency alignment
package.json, packages/cta-admin/package.json
The pnpm override and cta-admin dependency now use react-router-dom 7.18.2. The obsolete @types/react-router-dom development dependency was removed.
Finder dependency update
packages/admin-bar/package.json
The @medv/finder dependency constraint changed from ^3.2.0 to ^4.0.2.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/runtime-dependencies-current

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

github-actions Bot and others added 3 commits August 6, 2026 01:45
@danieliser
danieliser marked this pull request as ready for review August 6, 2026 01:58
@danieliser
danieliser merged commit 0de5132 into develop Aug 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant