Repository navigation
fix: 馃悰 use null-prototype maps in local API key and signer stores - #375
Merged
Merged
Conversation
Lookups in the local API key store and local signer address book now only match entries that were explicitly configured or added.
|
F-OBrien
approved these changes
Sep 28, 2026
Contributor
Author
|
/fast-forward |
1 of 4 tasks
Contributor
|
馃帀 This PR is included in version 9.0.1-alpha.1 馃帀 The release is available on GitHub release Your semantic-release bot 馃摝馃殌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalApiKeysRepo.apiKeysandLocalSigningService.addressBookare now created withObject.create(null), so lookups only match entries that were explicitly configured or added.Stacked on #374 (
fix/sonar-quality-gate); merge that first.Test plan
jest src/datastore/local-store/repos/api-key.repo.spec.ts src/signing/services/local-signing.service.spec.ts(23 passed; new cases fail without the fix)eslintandtsc --noEmitclean馃 Generated with Claude Code