Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Docker HEALTHCHECK instruction in the distroless image. The gcr.io/distroless/cc base image contains no shell, but Docker's HEALTHCHECK CMD in shell form requires /bin/sh to be present. The fix introduces a new BusyBox build stage and copies /bin/sh from it into the final image.
Changes:
- Adds a
busybox:stable-uclibcintermediate build stage - Copies
/bin/shfrom BusyBox into the distroless final image to satisfy the shell requirement of the HEALTHCHECK instruction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Neopallium
force-pushed
the
fix_distroless_healthcheck
branch
from
dc769c9 to
9271b7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
other