ci(windows): fix prereq build on new windows-latest (VS2026 / CMake 4)#349
Open
darkclad wants to merge 1 commit into
Open
ci(windows): fix prereq build on new windows-latest (VS2026 / CMake 4)#349darkclad wants to merge 1 commit into
darkclad wants to merge 1 commit into
Conversation
1. find_package() could not locate DCMTK/OpenJPEG configs even though the libs installed fine (DCMTK builds against openjpeg). Cause: relative -DCMAKE_PREFIX_PATH=../../local_install is not honored by config-mode find_package() on CMake 4.x (verified locally on cmake 4.2.1: relative prefix fails to find an installed package config, absolute succeeds). Use an absolute ABS_INSTALL path for all -DCMAKE_PREFIX_PATH values. 2. Mirror install_prereq_linux.sh: add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to older dependency configures (CMake 4 dropped < 3.5 compatibility), so the independently built z5/Arrow stack does not fail silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_package() could not locate DCMTK/OpenJPEG configs even though the libs installed fine (DCMTK builds against openjpeg). Cause: relative -DCMAKE_PREFIX_PATH=../../local_install is not honored by config-mode find_package() on CMake 4.x (verified locally on cmake 4.2.1: relative prefix fails to find an installed package config, absolute succeeds). Use an absolute ABS_INSTALL path for all -DCMAKE_PREFIX_PATH values.
Mirror install_prereq_linux.sh: add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to older dependency configures (CMake 4 dropped < 3.5 compatibility), so the independently built z5/Arrow stack does not fail silently.