Repository navigation
Guard model-v2 binding inputs and build admission - #29
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Merged into
|
vahid-ahmadi
added a commit
that referenced
this pull request
Oct 15, 2026
…ged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses items 2–4 of Vahid Ahmadi's 12 October review, branching from
model-v2. Item 1 is handled separately.jobs.pyapplies the existinghost.assessrule before uncached engine batches and after acquiring each slot. Floors match Part J: 40 GiB before Enhanced FRS batches, 40 GiB per configured Microcosm worker before their batches, and 40 GiB at each launch. Decisions reach job-cache records and model provenance; cache reuse is identified without a launch. Refused launch decisions survive aggregated exceptions. The CLI and binding runbook default to one Microcosm worker.C2_BUDGET_DATE; regressions move the constant and accept full month, abbreviated month, ISO date and ISO timestamp sources while rejecting the old date.Invariants: the rounding interval contains the true unrounded growth rate. For finite host readings, admission refuses if and only if available memory is below the floor or one-minute load is above the per-CPU limit × CPUs; non-finite readings also refuse. Admission does not change fiscal cache keys or computed fiscal values. Explicit Part J admission callbacks and injected runners retain their own guards.
The requested rehearsal logs contain no measured Microcosm worker peak memory. They show two cold paths run sequentially on one worker (556 s and 675 s); the receipt's 66.42, 66.60 and 83.82 GiB observations are available host memory, not worker peaks. The historical 31.8 GB Microcosm peak predates the net-support changes and does not support increasing concurrency. Sources:
rehearsal-sample-1-1791792698.logunder the scheduled-job logs and.cache/J-rehearsal/sample-receipt.jsonin the rehearsal worktree.Validation: tests cover all 16 committed CPI Septembers and 17 AWE windows, deliberately wrong rates, 500 randomized rounding examples, vintage revisions, scheduler thresholds and slot rechecks, cached provenance, and moved Budget dates. The initial focused suite passed 222 tests; the review-fix suite passed 166 tests, including six actual bridge-to-scheduler regressions. The final rounding suite passed 13 tests. The hard-tier independent review's callback conflict is fixed and committed. Final full
pytest -n 4, follow-up independent review, and CI on head905a3aeare pending; results will be updated before this task finishes. This PR is draft because the three documented stale-results checks require the later binding rebuild. CI permits only those existing exceptions for draft PRs targetingmodel-v2; every other failure remains blocking.The
REBUILD.mdchanges are a self-contained guards block plus the worker-count and admission corrections. They may need a trivial rebase after #28. No merges or direct writes tomodel-v2.🤖 Generated with Claude Code