Skip to content

Temporarily handle missing ACS WIC participation inputs - #566

Merged
anth-volk merged 4 commits into
mainfrom
fix/560-temporary-acs-wic-compatibility
Oct 9, 2026
Merged

anth-volk merged 4 commits into
mainfrom
fix/560-temporary-acs-wic-compatibility

Conversation

@anth-volk

Copy link
Copy Markdown
Contributor

Fixes #560

Scope

This replaces #562 with a narrowly scoped temporary ACS WIC compatibility fix
on fix/560-temporary-acs-wic-compatibility, based on refreshed main.

  • Fill only missing legacy participation decisions on people explicitly
    identified as acs_2024_1yr with True.
  • Preserve every valid existing ACS and donor decision and leave country-model
    eligibility unchanged.
  • Continue to reject missing donor decisions, missing identifying provenance,
    and malformed values.
  • Add focused mapping and real country-model integration tests, an obvious
    removal comment, and a short replacement runbook.

No source partitioning, state/year preparation APIs, dataset-loader refactoring,
prototype tests, dataset certification changes, or dependency-pin changes are
included. The prototype remains separate and must not ship with this fix.

Follow-up

The Microcosm code repair is PolicyEngine/microcosm#1156. Rebuild and publication
of a replacement dataset are tracked separately by PolicyEngine/microcosm#1154.
The removal draft #563 remains blocked until that actual replacement is
published and certified; merging the generator repair alone is insufficient.

After this fix is released, PolicyEngine/policyengine-sim-api#726 and
PolicyEngine/policyengine-api#3868 must adopt the corrected publication rather
than the affected 6.2.2 release. The normal release workflow determines the next
version; this PR does not manually publish a package.

Validation

  • Focused mapping and real country-model integration tests: 87 passed.
  • Repository format and lint targets using the CI Ruff version: passed.
  • No full test suite, paid compute, data rebuild/publication, or service deployment.

@anth-volk
anth-volk force-pushed the fix/560-temporary-acs-wic-compatibility branch from 7e6ef94 to 4d2541d Compare October 9, 2026 14:21
@anth-volk
anth-volk marked this pull request as ready for review October 9, 2026 17:27
@anth-volk
anth-volk merged commit b88fbf8 into main Oct 9, 2026
13 checks passed
@anth-volk
anth-volk deleted the fix/560-temporary-acs-wic-compatibility branch October 9, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Temporarily handle missing ACS WIC participation inputs

1 participant