Repository navigation
Add variable labels from OpenFisca - #244
Merged
Merged
Conversation
nwoodruff-co
left a comment
nwoodruff-co
left a comment
Contributor
There was a problem hiding this comment.
Does this have other bits in it's not meant to?
Contributor
Author
|
It for sure does, thanks for flagging @nwoodruff-co |
OpenFisca variables have a `label` class attribute with human-readable names (e.g. "Employment income"). This adds `label: str | None = None` to the Variable model and extracts it via `getattr(var_obj, "label", None)` in both US and UK model loading. Includes unit and integration tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
anth-volk
force-pushed
the
add-variable-labels
branch
from
March 11, 2026 20:25
10f1e70 to
5811c7a
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 16, 2026
Round 8 of #635: GitHub records a retarget it makes itself, when a pull request's base branch is merged and deleted, as an AutomaticBaseChangeSucceededEvent, which a query for BASE_REF_CHANGED_EVENT alone misses (live: #244). The base-change query now asks for both, so a pull request automatically retargeted to main is counted like one a person retargeted. The GraphQL fake now answers only for the event types a query asks for, and new cases cover an automatic retarget of the candidate's own and of a closed pull request; dropping either event type from the query fails a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243
Summary
label: str | None = Noneto theVariablePydantic modelgetattr(var_obj, "label", None)in US and UK model loadingvariable_label_fixtures.py) and 15 tests covering model, extraction, and integrationTest plan
TestVariableLabelField— Variable model accepts/defaults labelTestLabelExtraction—getattrpattern handles present, missing, empty labelsTestUSVariableLabels— US model variables have labels, >50% coverageTestUKVariableLabels— UK model variables have labels, >50% coverage🤖 Generated with Claude Code