Repository navigation
Conversation
PR Review: Add state tax comparison outputs and caller documentationPR #10310 (author: MaxGhenis), head What the PR adds:
Who consumes it. The PR body says the outputs come from the Yale/PSL outside-modeler triage. The docs link them to the TAXSIM dashboard's "Within 1%, net of rebates" column. That column's PolicyEngine Sources read for this review (all fetched 2026-10-21):
SummaryWhat is right:
There are no critical findings and three should-address items:
There are also four suggestions: Virginia wording after #10277, an optional bound on the California input, a Colorado year inconsistency in the docs, and the PR body. Status:
Critical (must fix)None. Should addressS1. The Axiom line
|
DTrim99
left a comment
There was a problem hiding this comment.
The new outputs are pure additions, follow each state's credit lists without double counting, and 18 expectations hand-check; no partner files are touched. Three should-address items: (1) the 'pending: hub files parity' axiom line is invalid (the CA input encodes R&TC 17143, so it needs a queued issue; the rest is n/a); (2) the one-time rebate registry is inconsistent (it has CO TABOR but not the OR kicker) and differs from policyengine-taxsim's list in CO/MA/ME/OR, though taxsim.md calls it the dashboard contract; (3) the CO 2022 case pins a $450 FAMLI premium that C.R.S. 8-13.3-507 starts in 2023, and #10154 would break it. Four suggestions. Full report in the comment above.
WIP: Add state-tax comparison outputs and clarify caller input conventions identified in the Yale/PSL triage.
Plan:
state_income_tax_rebate_adjustmentandstate_income_tax_before_one_time_rebateswith an additive reconciliation contract. The registry covers 17 states, follows existing dated credit lists and amount gates, respects Virginia/South Carolina liability caps, and sums person-level Massachusetts/Montana amounts. Ordinary credits, filing elections, and other credit bases remain fixed.ca_out_of_state_municipal_bond_interestinput (default 0), document the California-source assumption, and exclude dependents' own interest from the parent's return. Federal AGI is unchanged.Validation: 67 cases passed across 7 files (57 new and 10 existing regression cases). Affected YAML files run individually in foreground processes, one at a time, with all requested thread caps set to four.
make format, lint, and the GitHub documentation build pass. CI test jobs were skipped for this draft PR. Microsimulation impact validation is left to the hub.Impact: none expected for existing inputs, since existing output behavior is preserved and the new California input defaults to 0. Supplying the new input explicitly adds the reported nondependent portion to California AGI. The comparison output preserves current rebate attribution and historical eligibility behavior; it does not rerun taxes under a counterfactual policy.
axiom: TheAxiomFoundation/rulespec-us#1860 queued. California R&TC 17143 (other states' bond interest added to California AGI): the statutes are in the pinned corpus release, the Schedule CA form text waits for the W6 re-pin, and the module waits for the hub's signed-encoder dispatch. n/a: the state income tax rebate adjustments, the pre-rebate comparison output, and the Alaska PFD and tax-unit role documentation change no calculated tax or benefit.