Repository navigation
Add New York state supplementation for 2026 - #10158
Conversation
… tests - Apply the not-married / not-head-of-household test to minors under 18 too, per person - Read is_full_time_student directly instead of a wrapper variable - Registry placement and comments, SNAP reference title, shorter programs.yaml note - Pinpoint SSL 209 and 18 NYCRR 398-4.4 references - Make the deeming test exercise deeming; add minor-branch and earned-income cases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Review: Add New York state supplementation for 2026PR #10158 (author: hua7450, head SummaryThe PR adds New York's State Supplement Program (SSP), which the Office of Temporary and Disability Assistance (OTDA) administers:
The 2026 policy content is right:
Three should-fix items remain:
Critical (must fix)None. Should address1.
2. The parameter descriptions don't follow the house template.
3. The PR body describes behavior the last commit removed.
Suggestions
Verified correct
Batch checks
Axiom line assessmentInvalid (Should 1).
CI statusAll 26 checks pass (
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
All 2026 amounts match SSL 209(2) and the OTDA 2026 chart. The taper follows 18 NYCRR 398-4.4(b) and SSL 209(4), the living arrangements and SSPNA income test are right, and all 42 cases check by hand. Three should items (see the comment above): (1) 'axiom: needed' isn't valid for staff, and rulespec-us has no Part 398 / SSL 209 module, so file a pe-parity issue and add a queued line; (2) all 10 NY parameter descriptions are off the template; (3) the PR body still describes the regular-attendance input that the last commit deleted, and its case count is out of date.
…ds allowance, care setting input - Congregate care couple rates follow Social Services Law 209(2)(c)-(e): two times the individual standard less the couple FBR, so they move with each federal increase; couple.yaml keeps the living alone and living with others amounts. - Under spousal deeming, follow 18 NYCRR 398-2.1(ac) and 398-4.4(b): the individual standard less the greater of the individual FBR or countable income including deemed income. A NOTE quotes SSA's method and SSL 209(4). - Personal needs allowance follows SSL 209(2-a) and 18 NYCRR 398-3.4: $25 by default in a Medicaid-majority facility, $5 for OPWDD and OMH facilities. - New ny_ssp_care_setting input; the living arrangement reads it, and foster children and members in a medical facility do not end living alone. - No state payment in an excluded setting or a Medicaid-majority facility. - Descriptions follow the template; references cite 398-3.4 and 398-4.2. - Tests: care setting inputs, couples after entry, deeming, facility and household-count cases, spm_unit_benefits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…into ny-ssp-2026
|
Thanks, David. The fixes are in db43e76, followed by a merge of Should 1 (Axiom line): filed TheAxiomFoundation/rulespec-us#1777 (
The source conflicts below are in a separate comment on that issue. The axiom line now points to it. Should 2 (descriptions): all ten New York files now follow the template, using the program's own name ("State Supplement Program", 398-2.1(af)), and the two personal needs files are distinct. I left the shared federal Should 3 (PR body): the regular-attendance sentence now says part-time attendance under 20 CFR 416.1861 is not modeled, the case count is 53, and the body closes #1478. Suggestion 1 (couple congregate care): fixed for future years; history stays out of scope.
Suggestion 2 (Texas rebate copy): filed #10226 to keep one Suggestion 3 (New York programs that read SSI): filed #10239 for CCAP (404.5(b)(5)(vi)) and HEAP code A (393.4(c)(1)(iii)). Both need this PR first. IT-214 is unaffected from 2025, as you noted. Suggestion 4 (personal needs allowance): fixed to follow SSL 209(2-a) and 398-3.4.
Suggestion 5 (the
Suggestion 6 (readings):
Suggestion 7 (polish):
On the merged head, these pass locally: the 53 New York cases, 243 federal SSI cases, and the aggregate list integrity and program registry tests (677 passed, 10 skipped). |
PR Review (round 2): Add New York state supplementation for 2026PR #10158 (author: hua7450). This round reviews head
SummaryZiming fixed all three round-1 should items. The axiom line now points to rulespec-us#1777, which is open, labelled The new logic checks against SSL § 209 and 18 NYCRR Part 398. The couple congregate-care rates now follow § 209(2)(c)-(e) in every year, including the 2015–2025 years round 1 flagged. The deeming, personal needs and care-setting changes follow 398-2.1, 398-3.4, 398-4.4 and 398-4.5. The New Hampshire bug pattern doesn't occur: mixed-state simulations run cleanly. All 53 cases pass locally and in CI. One new should item: the rewritten living-alone count leaves out a claimant who is in foster care. So a disabled foster youth living with one foster parent gets the $87 living-alone rate instead of $23. Round-1 findings status
New findingsCritical (must fix)None. Should address1. A claimant who is in foster care is left out of their own household count, so the living-alone test inverts.
Suggestions1. Case 40 pins the federal model's deeming for a spouse in a nursing home, and its comment states it as law.
2. With one marital unit, a spouse whose partner is in an excluded setting gets a quarter of the couple supplement.
3. The two skipped readings don't need tuned incomes (optional). Both are plain inputs. I ran them at the head:
4. Two small additions to the axiom line and #1777.
Verified
Axiom line assessmentValid:
CI status25 pass, 1 fail (infrastructure), 1 pending (
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
Requesting changes for 1 should item; details in the round-2 report above. All three round-1 should items are fixed. rulespec-us#1777 is ready for the encoder, the descriptions follow the house template, and the PR body is current. The FBR-derived couple care rates, the deeming fixes, the $25 personal needs allowance default and the new care-setting input all check out. The NH-sibling bug doesn't occur here (NY+MA, NY+CA+PA and NY+NJ simulations run cleanly), and 53 of 53 tests pass. Should 1: the living-alone count at ny_ssp_living_arrangement.py:59-62 leaves out a claimant who is in foster care. Example: a disabled 19-year-old foster youth with one foster parent gets LIVING_ALONE $87 instead of $23, and one actually living alone gets $23 instead of $87. Fix: count the claimant themselves (verified in scratch; all 53 cases still pass), and add a case. CI note: the Baseline (household) failure is a runner shutdown (exit 143), not a test failure; re-run it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A claimant in foster care now counts as living with others when they share a home, and as living alone when they don't (18 NYCRR 398-4.5). Family care residents and members in another care setting no longer end living alone. Relabel Cases 40 and 41 and add Cases 43-48. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, David. The fixes are in 5927d59, after a merge of Should 1 (claimant in foster care): fixed. The living-alone count now looks only at a person's housemates, never the person themselves, so a claimant's own foster status no longer matters (
Suggestion 1 (Case 40): took the second option. Case 40 now enters the nursing-home resident and the ineligible spouse at home as separate marital units, with a comment citing 20 CFR 416.1160(a)(1), 416.1167(a)(2) and 416.212. It asserts SSI
Suggestion 2 (Case 41): took the second option. Case 41 now asserts SSI
Suggestion 3 (the two skipped readings): added both, with your figures:
Suggestion 4 (axiom line and rulespec-us issue):
CI (Baseline household): agreed, a runner shutdown. I didn't rerun it; this push starts a new run. The On the merged head, the 59 New York cases pass locally (48 in |
PR Review (round 3): Add New York state supplementation for 2026PR #10158 (author: hua7450). This round reviews head
SummaryZiming fixed the round-2 should item and acted on all four suggestions:
CI is 27/27 green on the head. Two optional suggestions remain. Montana's SSP has since merged to Prior findings status
New findingsCritical (must fix)None. Should addressNone. Suggestions1. Record the reading for two foster youths who share a home (optional).
2. One parenthetical in the PR body (optional). The body says "Separate marital units give the correct result ( Verified
Axiom line assessmentValid:
CI status27 pass, 0 pending, 0 failed (run 39375864951 on head
Branch status
Verdict: APPROVE |
DTrim99
left a comment
There was a problem hiding this comment.
Approving round 3; details in the report above. Round 2's should item is fixed: the living-alone count now covers only housemates, so a claimant in foster care is no longer left out. Cases 43 and 44 pin both directions ($23 and $87), and the wider fix also makes the separate-unit workaround work for an excluded spouse (Case 45). All four suggestions are addressed or reasonably declined, and #1777 matches the head with 209(1)(d) and 398-4.2(b) added. The four hand resolutions in merge 00d658c are correct, and the 2027 COLA changes no 2026 result. All 8 new or changed expectations check by hand, and CI is 27/27 green. Branch note: Montana #8233 landed on main after this head and causes 3 conflicts (HUD, programs.yaml, spm_unit_benefits.py); keep both lines. Two optional suggestions are in the report.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What and why
New York's State Supplement Program was missing from PolicyEngine-US. Add
ny_sspwith the verified 2026 standards of need for living alone, living with others and the three certified congregate care levels (with the downstate premiums). It also includes the State Supplemental Personal Needs Allowance for SSI recipients in Medicaid facilities.Closes #1478.
New York has administered its supplement itself since October 1, 2014, so the payment uses New York's own $1 minimum (18 NYCRR 398-4.6(c)) and no SSA rounding. The shared SSI state supplement helper (
_ssi_state_supplement.py, identical to the copy in the sibling state SSP PRs) handles the income taper and couples. New York's own rules on top of it:ny_ssp_care_settinginput sets the certified care levels, OPWDD and OMH facilities and excluded settings. Living alone counts only a person's housemates, never the person themselves. Foster children, family care residents and members living in a facility or another care setting don't end it (18 NYCRR 398-4.5(a)).ny_ssp_is_minorfor it.The supplement is added to household and SPM benefit totals and to SNAP and HUD unearned income. #10239 tracks New York CCAP and HEAP reading the supplement after this PR.
References
Additional section citations are included alongside the parameters and formulas.
Coverage limits
The registry marks New York as partial, verified for 2026. Grandfathered mandatory payments are not modeled. Earlier years use parameter backfilling and are unverified historical estimates, and no historical rate coverage is claimed.
Two federal SSI limitations carry over for spouses who live apart. With one marital unit, the federal model deems an ineligible spouse's income to a nursing-home resident on the $30 benefit. It also keeps the couple computation when a spouse is in a facility Medicaid does not mostly pay for or in an excluded setting. Separate marital units give the correct result (
ny_ssp.yamlCases 40 and 45; Case 41 pins the one-unit result).Related: #10226 tracks the reform copies of
spm_unit_benefits(such as the Texas rebate's), which this PR leaves unchanged.Test plan
ny_ssp.yamland 11 inintegration.yaml. They cover:spm_unit_benefitsintegration.main: the 59 New York cases pass locally, and the aggregate list integrity and program registry tests pass (692 passed, 10 skipped).ruff formatandgit diff --check.changelog.d/.axiom: N.Y. Soc. Serv. Law § 209(1)(d), (2), (2-a), (3), (4); 18 NYCRR 398-2.1, 398-3.2, 398-3.4, 398-4.2(b), 398-4.4, 398-4.5, 398-4.6(c) TheAxiomFoundation/rulespec-us#1777 queued