Repository navigation
Conversation
Collaborator
|
UK hub (Claude session, for Max): this draft passes CI and is mergeable, and Max asked on 22 Oct to clear the UK PR backlog before the Budget. I've queued an independent review of this PR with seven of your other Housing Benefit drafts, and will mark it ready and land it through the merge queue if the review approves at this head. @anth-volk, reply here if you'd like it held or you're still changing it. |
MaxGhenis
marked this pull request as ready for review
October 22, 2026 18:15
Brings the branch up to date and runs the checks main now requires (Test / Result, Lint); this branch's last CI predates those workflow names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Aggregate impact on certified data: passBase Checks: 0 broken by this change, 1 failing on both sides, 0 fixed. Moves flagged for review: 0 (thresholds in Notes
Moves flagged for reviewNone. Spending by benefit and service
Caseloads
Household net income by decileNo household's net income changes in any year. No change in any year: receipts by tax head; government balance, each component counted once; model totals; household income totals; population; poverty rates; people in poverty; inequality; mean household net income in each side's own deciles; standard reform costings (change in gov_balance); standard reforms: change in each reform's target. Checks failing on both base and head (1)
Counted-once checkEach of 84 components was raised by £1 per unit in 2026-27, and every head of its totals was read household by household: its own head must rise by exactly £1, no other tax head may move, no other benefit may rise, and the model's own total must move by what its heads moved. A head that breaks a rule is measured again twice: with every other head held at its baseline value, and with every other head held at its value after the first £1 while the component rises again. It fails where either still shows the response. 0 failed; 0 were skipped. Provenance
Dataset: Receipts by tax head: head levels
Spending by benefit and service: head levels
Caseloads: head levels
Government balance, each component counted once: head levels
Model totals: head levels
Household income totals: head levels
Population: head levels
Poverty rates: head levels
People in poverty: head levels
Inequality: head levels
Mean household net income in each side's own deciles: head levels
Standard reform costings (change in gov_balance): head levels
Standard reforms: change in each reform's target: head levels
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2208
Corrected the ordinary pension-age Housing Benefit capital tariff threshold from £6,000 on 10 April 2006 to £10,000 on 2 November 2009. The current £10,000 amount is unchanged. References sit beside both dated values: original regulation 29(2)(b) and SI 2009/1676, regulations 1 and 5.
Approved plan A3 only: three files, no new inputs or formula changes. This does not add a residential category, alter capital valuation, change the model's pre-2015 calculation support, or duplicate #1969/#1974/#2131/#2201.
Validation: five new direct parameter-history tests passed, including immediately before/at commencement and the retained current value;
make formatandgit diff --checkpassed. Tests read the enacted parameter history before fiscal-year conversion (which starts in 2015). No full suite, population simulation or CI polling. Existing core 3.32.13 environment, not a fresh lock sync.Merge dependency: none.
axiom: needed
Reproducer:
policyengine_uk/tests/test_housing_benefit_capital_threshold_history.py