Repository navigation
Skip redundant dataset copy in apply_uprating - #1523
Merged
Merged
Conversation
…_single_year_dataset Add copy=False parameter to apply_uprating; extend_single_year_dataset passes copy=False since it already copies each year individually via dataset.copy(). This removes the unnecessary deep copy of the entire multi-year dataset.
3 tasks done
vahid-ahmadi
added a commit
that referenced
this pull request
Oct 8, 2026
#1209 reported PolicyEngine UK producing slightly different aggregates on ubuntu-latest vs macos-latest CI. The triage narrowed it to dict-iteration-order differences in apply_uprating's tree walk (closed fix attempt PR #1223). A series of follow-on PRs since rebuilt the affected uprating code path: - #1254 added multi-year datasets and separated uprating into a discrete pipeline step; - PRs #1543 / #1544 / commit 13a4ac7 rebuilt uprate_rent which was the primary visible site of divergence; - #1523 skipped a redundant dataset copy in apply_uprating. CI runs on ubuntu-latest only, so there's no live cross-OS test to prove the issue is fully resolved. Persist the diagnosis as a known- issue page so that, if reproducibility regression resurfaces, the next person doesn't have to re-derive the root-cause shape. Includes a sketched minimal regression test for reintroducing deterministic ordering once a cross-OS CI matrix is restored.
vahid-ahmadi
added a commit
that referenced
this pull request
Oct 12, 2026
#1209 reported PolicyEngine UK producing slightly different aggregates on ubuntu-latest vs macos-latest CI. The triage narrowed it to dict-iteration-order differences in apply_uprating's tree walk (closed fix attempt PR #1223). A series of follow-on PRs since rebuilt the affected uprating code path: - #1254 added multi-year datasets and separated uprating into a discrete pipeline step; - PRs #1543 / #1544 / commit 13a4ac7 rebuilt uprate_rent which was the primary visible site of divergence; - #1523 skipped a redundant dataset copy in apply_uprating. CI runs on ubuntu-latest only, so there's no live cross-OS test to prove the issue is fully resolved. Persist the diagnosis as a known- issue page so that, if reproducibility regression resurfaces, the next person doesn't have to re-derive the root-cause shape. Includes a sketched minimal regression test for reintroducing deterministic ordering once a cross-OS CI matrix is restored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copyparameter (defaultTrue) toapply_upratingso callers can opt out of the defensive deep copy of the full multi-year datasetextend_single_year_datasetnow passescopy=Falsesince it already copies each year individually viadataset.copy()— the second copy was redundantapply_upratingretain the existing safe-by-default behaviourThis is the proper upstream fix for the monkey-patch used in policyengine.py#251 to avoid the redundant copy in the UK simulation run.
Test plan