Skip to content

Aggregate impact: another reform's target can withhold a reform's year #2775

Closed

Description

@MaxGhenis

withheld_reasons (policyengine_uk/utils/aggregate_impact/measure.py) checks every entry in baseline["targets"], which holds the target of each reform the tool costs. A reform that moves another reform's target in 1 to 9 records therefore loses that year's costing and its own target change, although the report publishes nothing about the other target for that reform.

test_a_small_change_in_another_reforms_target_names_that_target in #2772 builds the case: the tool withholds a reform aimed at income tax because the reform moves Pension Credit in three records.

withheld_reasons already checks gov_balance, which covers the reform's whole costing, so checking the reform's own target beside it would publish these years. That change needs one check first: that no other published figure for the reform reads the other target.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions