Repository navigation
Conversation
policyengine-comparables-review is the operating procedure for the gate policyengine-app-v2 CI enforces: search every producer on the scorecard's list, stage what is found under the harvest rules, compare with the analysis's own figures, and explain every gap over the threshold. Ships a Subfleet research brief and /comparables-review, and makes the review a required step in /deploy-dashboard, /new-tool, /create-dashboard, report-logger drafts and the writing checklist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Max, 2026-10-21: "even if we've already published something, we should do a fresh comp review before big pushes like newsletters". Adds the Before a push section and the prepromotion search kind to the comparables review, and makes the freshness check a required first step of /generate-content and the content orchestrator, and of the writing checklist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The background job gets a writable workspace and gh push access, and the brief covers every search kind, pushes a draft PR even with an unexplained gap, and writes a pending cause that cites its issue. The skill lists the record's fields, the evasions never to use, a reviewer checklist, US sign conventions and fiscal years, the calculator path, and the commands as CI runs them. A pending gap blocks a push. Dashboards are reviewed before they are public. The brief is renamed search-brief.md, and the catalog manifest is regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
basis_note and program_note, the price base, unstated basis or prices, percent figures, range dashes, one-sided bounds, and hashing the documents annotations cite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
/new-tool and /deploy-dashboard review before anything is public, wire the zone through appZoneRoutes.ts, and use a registry template app-v2 accepts. The tracker route is reviewed too, as a tracker record. The skill states the listing-day, banner and proxied-page rules, the deployments field, record's latest-search default, report's tolerance of unexplained gaps, the Python 3.12 suite, and that window totals are not compared yet. The brief repins after superseding estimates. The catalog manifest is rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
Contributor
Author
|
Heads-up: #107 merged into main (8315e46). It adds a CI job, git fetch origin && git rebase origin/main
uv run python scripts/build_manifest.py
uv run python scripts/build_manifest.py --checkThen commit the rebuilt manifest. The builder now needs PyYAML, which |
Keep main's 4.2.0 bundles and added skills alongside the comparables wiring, and rebuild the manifest for the merged sources. Co-Authored-By: Codex <noreply@openai.com>
Document known enforcement gaps, complete deployment and tracker metadata handoffs, regenerate iframe route maps and cover calculator, deployment and local-file promotion. Preserve unexplained drafts without running index builds that reject them. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PolicyEngine analysis needs a comparables review before publication and a fresh review before promotion. This PR supplies the operating procedure, background search brief and command wiring.
What changed
origin/main, retain its 4.2.0 bundles and added skills alongside comparables wiring, and regenerate the dashboard manifest with the deterministic builder. The catalog now has 26 skills, 36 agents, 21 commands and eight bundles.deploymentsand actualpublishedmetadata after deployment, regenerate the index/feeds, merge the follow-up before registration/promotion, and explicitly verify direct URLs resolve through scorecard metadata alone.explains_gap: falseannotations and defer generated builds/merge until validation passes.The skill and command remain in complete, analysis-tools, dashboard-builder and app-development. Companion repositories are unchanged.
Companion PRs and merge order
Remaining companion defects include semantic scorecard evasions and the existing-annotation report failure, unregistered HTML/zone routes, omitted absolute redirect aliases and unrecognized delisted deployments when metadata is empty. The procedure describes these limits and supplies manual checks; it does not claim they are mechanically fixed. Required checks, rulesets, CODEOWNERS enforcement and cutover choices remain policy decisions.
Verification
uv run pytest --ignore=tests/test_skill_examples.py -q: 632 passed, six skipped; five failures came from a test-only macOS temp wrapper that incorrectly prefixed explicit paths.uv run pytest tests/test_review_program_snapshot.py tests/test_codex_command_skills.py -qpassed all 15 tests after restricting that wrapper to argument-freemktemp, verifying all 637 tests across the full run and focused retry. Every run used its own scratchTMPDIRand--basetemp, one worker; scratch was removed afterwards.uv run python scripts/build_claude_wrapper.py --source-root . --output-root <scratch>: passed; packaged skill, brief and command match the sources.uv run python scripts/build_manifest.py --check: passed after regeneration.bun run buildindashboard/: passed.After merge, refresh app-v2's AI agents stats (26 skills, 36 agents, 21 commands, eight bundles): PolicyEngine/policyengine-app-v2#1397.