Skip to content

Let the v2 report coordinator return its typed result instead of writing Stage 12 rows #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anth-volk wants to merge 3 commits into from
Closed

Let the v2 report coordinator return its typed result instead of writing Stage 12 rows #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e533dc7
Let report simulations return their artifact without database rows
anth-volk Oct 19, 2026
cd93bd5
Add the report coordinator's return mode
anth-volk Oct 19, 2026
cbb35b1
Type the child wait callbacks of both report coordinator modes
anth-volk Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions projects/policyengine-simulation-executor/src/modal/v2_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from pathlib import Path
from typing import TYPE_CHECKING

from policyengine_simulation_contract.stage12_execution import ReportResultDelivery
from policyengine_simulation_contract.stage12_manifest import v2_application_name
from policyengine_simulation_executor import stage12_runtime
from policyengine_simulation_executor.hf_access_validation import (
Expand Down Expand Up @@ -423,7 +424,7 @@ def run_single_simulation_uk(
def coordinate_report(
payload: dict,
context: dict,
parent: dict,
parent: dict | None = None,
*,
observability_context: dict | None = None,
) -> dict:
Expand All @@ -432,6 +433,10 @@ def coordinate_report(
A ``production_function_call_id`` in ``context`` marks a shadow run whose
result is compared with that production job's. A report another
invocation already claimed returns a ``deduplicated`` marker instead.

A ``result_delivery`` of ``return_to_caller`` in ``context`` takes no
``parent`` and writes no database rows: the report returns a
``ReportExecutionResult`` payload or raises ``ReportExecutionError``.
"""
from policyengine_simulation_executor.stage12_runtime import ( # noqa: PLC0415 # Modal function body: loaded in the worker container, not at deploy time
coordinate_report as run_report_coordinator,
Expand All @@ -452,19 +457,21 @@ def coordinate_report(
if context.get("production_function_call_id")
else STAGE12_CANONICAL_REPORT_STAGES
)
attributes = {
"runner_name": "stage12",
"execution_mode": (
"shadow" if context.get("production_function_call_id") else "authoritative"
),
}
if context.get("result_delivery") == ReportResultDelivery.RETURN_TO_CALLER:
# Telemetry tells returned reports apart from Stage 12 runs.
attributes["result_delivery"] = ReportResultDelivery.RETURN_TO_CALLER.value
try:
propagated = normalize_observability_context(observability_context)
result = None
with runtime.operation(
stage_plan.name(Stage.STAGE12_COORDINATOR_EXECUTION),
attributes={
"runner_name": "stage12",
"execution_mode": (
"shadow"
if context.get("production_function_call_id")
else "authoritative"
),
},
attributes=attributes,
remote_context=propagated,
):
result = run_report_coordinator(
Expand Down
Loading
Loading