Repository navigation
Report numeric mixed fractions as unread factors in the AB2026 checker - #252
Merged
Merged
Conversation
The checker read "x 2 and a half" as a factor of 2, so "4" under it passed at 8. It now reports a factor that "and" and a fraction follow, at any value. We also add the locator rows for repeated closing square brackets, which a mutant allowing one such bracket passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sol's review of 8200b41 found that two spaces or a tab hid the fraction in "x 2 and a half", so "4" under it passed at 8. The checker now reads any run of whitespace in a note as one space, as it already does in value_raw. We add three rows to the mixed-fraction matrix, a Hypothesis test that widens a space in 14 notes, and a clause in the README's list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"sign from the wording; x 2" with two spaces reported an opposite sign at -8, though the README says the checker reads any run of whitespace in a note as one space (Sol, review of c9027fe). The checker now lower-cases the note and collapses its whitespace before it reads a worded sign, as it does before it reads a factor. The whitespace test now compares factors and complete problem lists, over every space in 20 notes, and Hypothesis tries all 29 whitespace characters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing and reopening so CI runs on |
MaxGhenis
pushed a commit
that referenced
this pull request
Nov 5, 2026
MaxGhenis
pushed a commit
that referenced
this pull request
Nov 5, 2026
The parametrized test tried six runs and left the other whitespace characters to Hypothesis's random draws, so a mutant that misread an em space after "sign" survived one run (cloud review of 58f1eb5). The test now tries all 29 characters at every space in each of the 20 notes, and compares factors and complete problem lists at 10 values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
November 5, 2026 21:07
Contributor
Author
|
We merged
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We answer two low findings from GPT-6.1 Sol's review of #231 at
4dd5281d, as part of #230, and the findings from its reviews of this PR at8200b418andc9027fe2. We also answer the two low findings from an Opus 5.5 cloud review of58f1eb5c.pipeline/ab2026_harvest_contract.pyread "x 2 and a half" as a factor of 2, so "4" under it passed at 8. The checker now reports a factor that "and" and a fraction follow, at any value: "x 2 and half", "/ 2 and a half", "x 2 and three quarters" and "x 1e6 / 2 and a half". We name the form in the README's list.8200b418). The checker missed the fraction in "x 2 and a half" when two spaces or a tab separated "a" from "half". It now reads any run of whitespace in a note as one space, as it already does invalue_raw, and we say so in the README.c9027fe2). The checker missed the worded sign insign from the wording; x 2, with two spaces after "sign", so "4" failed at −8. It now lower-cases a note and collapses its whitespace before it reads a worded sign, as it does before it reads a factor.58f1eb5c). The parametrized test tried six runs and left the other whitespace characters to Hypothesis's random draws, so a mutant that misread an em space after "sign" survived one pass of the test file. The test now tries each of the 29 characters at every space in the 20 notes.We stage none of these forms in the 5,952 rows, and the checker still finds 0 problems in the 12 families.
Invariants
Checks
tests/test_ab2026_harvest_contract.pypass.🤖 Generated with Claude Code