Resize model page iframe dynamically to push footer to bottom#698
Draft
PavelMakarchuk wants to merge 1 commit intomainfrom
Draft
Resize model page iframe dynamically to push footer to bottom#698PavelMakarchuk wants to merge 1 commit intomainfrom
PavelMakarchuk wants to merge 1 commit intomainfrom
Conversation
Listens for height messages from the embedded policyengine-model app and resizes the iframe to match content, so the footer only appears when scrolling to the bottom. Closes #697 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postMessagefrom the embedded policyengine-model app with content heightcalc(100vh - 200px)until the first height message arrivesDepends on PolicyEngine/policyengine-model#3 being deployed first.
Related
Test plan
/us/model— iframe should fill content height, footer at bottom only when scrolled🤖 Generated with Claude Code