Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
app/src/pages/BenefitAccess.page.tsx
Outdated
| title="Benefit Access" | ||
| description="Powering benefit eligibility screening tools through the PolicyEngine API" | ||
| /> | ||
| <Space mb={20} /> {} |
There was a problem hiding this comment.
Question: What is the purpose of the empty object after closing ?. This appears to be leftover development code.
Suggestion: Use Mantine's spacing props on surrounding components instead of adding extra spacing components.
There was a problem hiding this comment.
Thank you for your work on this, @Swetna! The page looks good overall. However, there have been some major updates to the codebase over the past couple of weeks. The current v2 pattern now uses:
- StaticPageLayout as the wrapper
- HeroSection for the title and description
- ContentSection for content blocks
- RichTextBlock with basic HTML for rich text
- Section dividers handled by ContentSection
Along with addressing the PR review comments, could you please rebase on the latest changes from main and update the PR accordingly?
Swetna
force-pushed
the
feat/benefit_access_page
branch
from
53e85e3 to
974ce6d
Compare
|
All updates have been made do let me know if everything looks ok. |
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
Submitting review comments for myself to handle later
| export default function BenefitAccessPage() { | ||
| const navigate = useNavigate(); | ||
| const handleExploreAPI = () => { | ||
| navigate('/us/api'); |
There was a problem hiding this comment.
Needs to use country ID flexibly
| }; | ||
|
|
||
| const handleContactUs = () => { | ||
| window.location.href = 'mailto:hello@policyengine.org'; |
There was a problem hiding this comment.
Needs to open in new tab; likely a better handler for this
| }; | ||
|
|
||
| const handleAboutPage = () => { | ||
| navigate('/about'); |
There was a problem hiding this comment.
Use absolute links; this will likely tack onto existing URL
| title="Benefit Access" | ||
| description="Powering benefit eligibility screening tools through the PolicyEngine API" | ||
| /> | ||
| <Space mb={20} /> |
| <CardsWithHeader | ||
| cards={[ | ||
| { | ||
| title: 'MyFriendBen', |
There was a problem hiding this comment.
Define cards outside as separate JSX and bring in in final render
4 participants
Created and formatted the Benefit Access page using the components.
Screenshot of page:
