Repository navigation
v3 validation: one related score per measure and year, calibration headlines first - #1442
Merged
Merged
Conversation
…n headlines first Related reforms (RelatedReformEstimates): - focusRelatedReformClaims keeps one score per measure, period and metric. A costing with a static and a post-behavioural leg for the same year keeps the static one, which PolicyEngine's static runs compare with. A year that both the source and PolicyEngine score as exactly zero, such as a year before the measure starts, is left out. - A row is titled with the measure as the source describes it (conditions.reform_hint, up to its first comma), not the publication. - The "Different baselines" note no longer runs under related reforms: they are other policies, so their own baselines say nothing about this report. - The section stays closed until the reader opens it. Data calibration (CalibrationMatchSection): - calibrationPreviewTargets puts each group's largest money target and largest count target first (a programme's spending and caseload), then the rest by gap. Six show at once; "Show all N <group> targets" opens the rest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v3 Validation tab showed too much for a UK report. On report 4828 ("UC minimum age reduction") it listed 26 related-reform rows (13 shown at first) and 88 Universal Credit calibration targets. This PR keeps the rows that inform the reader and puts the rest one click away. v3 only; v2 is unchanged.
Related reforms
focusRelatedReformClaims). HM Treasury prints a static and a post-behavioural leg for each year of a costing, and both appeared under the same title. The static leg is kept, because PolicyEngine's runs are static (else the leg PolicyEngine marks comparable).conditions.reform_hint, up to its first comma) instead of the publication title repeated on every row.Data calibration
calibrationPreviewTargets). Each group shows its largest money target and largest count target (a programme's spending and caseload), then the targets with the largest gaps, six in all. "Show all N targets" opens the rest.Checks
tsc --noEmit, ESLint and Prettier pass.components/flagship,libs/flagshipandpagespass (2,150 tests). New tests: the leg collapse, the zero-zero filter, the measure title, the absent baseline note, the closed section, and the calibration preview order. Existing tests updated to open the related-reforms section first.Overlap
CalibrationMatches.tsx(variable-name loading near the top ofCalibrationMatchSection); this PR edits the table rows further down.ScorecardComparisons.tsx(the fetch near the end); this PR edits the related-reforms component.🤖 Generated with Claude Code