Skip to content

Respect parameter visibility in reform search #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PavelMakarchuk merged 2 commits into from
Oct 26, 2026
Merged

Respect parameter visibility in reform search #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
260dd81
Hide compatibility parameters from reform search
juaristi22 Oct 22, 2026
710e107
Remove local evidence helpers from parameter visibility tests
juaristi22 Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/libs/metadataUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export const selectSearchableParameters = createSelector(
.filter(
(param): param is ParameterMetadata =>
param.type === 'parameter' &&
!!(param.economy || param.household) &&
!!param.label &&
!EXCLUDED_PARAMETER_PATTERNS.some((pattern) => param.parameter.includes(pattern))
)
Expand Down
46 changes: 46 additions & 0 deletions app/src/tests/fixtures/libs/metadataUtilsMocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import { transformMetadataPayload } from '@/libs/metadataUtils';
import type { RootState } from '@/store';
import type { MetadataApiPayload } from '@/types/metadata';
import type {
ParameterMetadata,
ParameterMetadataCollection,
} from '@/types/metadata/parameterMetadata';

export const TEST_FIELD_NAMES = {
STATE_NAME: 'state_name',
Expand Down Expand Up @@ -103,3 +107,45 @@ export const mockStateWithMetadata = (
},
} as Partial<RootState>;
};

// Search visibility follows buildParameterTree; API defaults arrive as explicit true flags.
export const SEARCH_VISIBILITY_CASES: Array<{
name: string;
flags: Pick<ParameterMetadata, 'economy' | 'household'>;
visible: boolean;
}> = [
{ name: 'true true', flags: { economy: true, household: true }, visible: true },
{ name: 'true false', flags: { economy: true, household: false }, visible: true },
{ name: 'true absent', flags: { economy: true }, visible: true },
{ name: 'false true', flags: { economy: false, household: true }, visible: true },
{ name: 'false false', flags: { economy: false, household: false }, visible: false },
{ name: 'false absent', flags: { economy: false }, visible: false },
{ name: 'absent true', flags: { household: true }, visible: true },
{ name: 'absent false', flags: { household: false }, visible: false },
{ name: 'absent absent', flags: {}, visible: false },
];
export const VISIBLE_SEARCH_PARAMETER: ParameterMetadata = {
parameter: 'gov.income_tax.basic_rate',
label: 'Basic tax rate',
type: 'parameter',
economy: true,
household: true,
};
export const SAME_LABEL_SEARCH_PARAMETERS: ParameterMetadataCollection = {
first: { ...VISIBLE_SEARCH_PARAMETER, parameter: 'gov.income_tax.basic_rate' },
second: { ...VISIBLE_SEARCH_PARAMETER, parameter: 'gov.capital_gains.basic_rate' },
};
export const SORTED_SEARCH_PARAMETERS: ParameterMetadataCollection = {
zulu: { ...VISIBLE_SEARCH_PARAMETER, parameter: 'gov.tax.zulu', label: 'Zulu rate' },
alpha: { ...VISIBLE_SEARCH_PARAMETER, parameter: 'gov.tax.alpha', label: 'Alpha rate' },
};
export const INELIGIBLE_SEARCH_PARAMETERS: ParameterMetadataCollection = {
node: { ...VISIBLE_SEARCH_PARAMETER, parameter: 'gov.income_tax', type: 'parameterNode' },
unlabelled: { ...VISIBLE_SEARCH_PARAMETER, parameter: 'gov.tax.unlabelled', label: '' },
cache: { ...VISIBLE_SEARCH_PARAMETER, parameter: 'gov.pycache.rate' },
};
export function searchVisibilityState(
parameters: ParameterMetadataCollection | undefined
): RootState {
return { metadata: { parameters } } as RootState;
}
Loading
Loading