Skip to content

Check the Table 2.5 EITC child splits against the real IRS rows in CI #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxGhenis wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Check the Table 2.5 EITC child splits against the real IRS rows in CI #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cbdfd1
Check the Table 2.5 EITC child splits against the real IRS rows in CI
MaxGhenis Oct 14, 2026
b9b0839
Tighten the Table 2.5 reconciliation wording (#1274 review)
MaxGhenis Oct 14, 2026
fd5b42c
Say what Table 2.5's footnote 1 states, not more (#1274 review)
MaxGhenis Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/eitc-t25-irs-reconciliation.added.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The SOI Table 2.5 EITC child-split targets are now checked in CI against the real IRS rows. A fixture holds the 274 pinned-feed rows for TY2023 Publication 1304 Table 2.5 and the TY2024 filing-season EITC by AGI, verbatim. Tests check that each split's AGI bins tile AGI and add to its total row, that the four splits add to the all-returns total, and that the totals reconcile within 10% with IRS-published EITC: the TY2023 source rows with TY2023 (more than 23 million returns, about $64 billion, 27/36/24/13% by children), and the compiled 2024 rows with TY2024 (about 24 million, $69.6 billion). Two Hypothesis properties on the real layout check that the compiled AGI bins and total rows both add to any filing-season EITC by AGI, and that each split's bins add to its total row under uniform growth. Before #1227 the compile halved the total rows (11.92 million returns and $34.52 billion), and these tests fail on that code.
Loading
Loading