Skip to content

Remove the unused TypeScript reader package - #16

Merged
anth-volk merged 1 commit into
mainfrom
chore/remove-typescript-reader
Oct 14, 2026
Merged

anth-volk merged 1 commit into
mainfrom
chore/remove-typescript-reader

Conversation

@anth-volk

Copy link
Copy Markdown
Contributor

Fixes #15

This removes the TypeScript reader @policyengine/microcosm-provider-orrery, which nothing uses. Its only intended consumer, PolicyEngine/microcosm-runs, keeps its own publication reader (PolicyEngine/microcosm-runs#4 was closed unmerged).

The Python distribution microcosm-emitter is unchanged, including graph publication queueing and upload in microcosm_emitter.orrery. It keeps publishing to PyPI through trusted publishing.

Changes

  • Deletes typescript/orrery/, the root package.json, tools/check-reader.sh, tools/check-reader-installed.ts and tools/publish-reader.sh.
  • ci.yml: removes the reader job and its orrery-reader artifact.
  • push.yaml: removes the publish-reader job, and the header comment now says only PyPI trusts this file. The required check in pr.yaml depends only on verify, so it needs no change.
  • tools/bump-version.py versions only pyproject.toml. tools/update-version.sh still runs towncrier and uv lock. The comments in it and in tools/check-changelog.sh now describe a single version.
  • tests/test_workflows.py:
    • Drops the reader and npm assertions.
    • Pins the full ci.yml and push.yaml job sets.
    • Replaces the diverged-version test with one that checks the release refuses a missing or duplicated version line in pyproject.toml.
  • README.md: the Publication section now covers PyPI only. The reader paragraph, bash tools/check-reader.sh and the reader-checks sentence are gone.
  • .gitignore: drops reader-dist/, typescript/orrery/dist/ and node_modules/. All three were added with the reader.
  • Adds the changelog fragment changelog.d/remove-typescript-reader.removed.md.

Release

The fragment is removed, so the version bump is minor. Merging releases 0.3.0, to PyPI only.

Validation

I ran these locally in the branch on macOS with Python 3.14:

Check Result
uv sync --locked Passed
uv lock --check Passed
bash tools/check-quality.sh Passed
uv run --no-sync pytest -m 'not collector' 248 passed, 9 deselected
bash tools/check-artifacts.sh Passed
bash tools/check-changelog.sh Passed: 0.2.1 -> 0.3.0
uv run --no-project python tools/bump-version.py --check Printed 0.3.0 and wrote nothing
actionlint 1.7.12 through Docker, at the digest pinned in pr.yaml No findings
git grep for provider-orrery, reader-dist, typescript/, npm and check-reader, outside CHANGELOG.md and uv.lock Matches only the new changelog fragment

I did not run:

  • The collector tests, which need the pinned collector checkout and a disposable PostgreSQL.
  • The Linux and Python 3.13 legs of the test matrix.

CI covers both.

This adds no environment variables or secrets. The removed publish-reader job used only OIDC. The versioning job still reads APP_ID and APP_PRIVATE_KEY, which are organisation Actions secrets and unchanged here.

After merging

These steps need an npm owner of @policyengine/microcosm-provider-orrery and are not part of this PR:

  • Do one of these:
    • Unpublish the package while npm still allows it. That is 72 hours from each version's publication, so before 2026-10-17 14:19 UTC for its earliest version, 0.0.0-stage.
    • Run npm deprecate on every version (0.0.0-stage, 0.1.0 and 0.2.1), pointing to Remove the unused TypeScript reader package #15.
  • Remove the package's npm trusted-publisher entry for push.yaml.

🤖 Generated with Claude Code

@policyengine/microcosm-provider-orrery has no consumer:
PolicyEngine/microcosm-runs keeps its own publication reader. Delete
typescript/orrery, the root package.json and the reader check and
publish scripts, and drop the reader CI job and npm publish job.

Releases now version only pyproject.toml and uv.lock and publish only
the microcosm-emitter Python distribution to PyPI. The workflow tests
pin the remaining job sets, and the diverged-version test becomes a
check that the release refuses a missing or duplicated version line.

Fixes #15

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@anth-volk
anth-volk marked this pull request as draft October 14, 2026 22:00
@anth-volk

Copy link
Copy Markdown
Contributor Author

Converting to draft; unsure on best repo for TypeScript reader package

@anth-volk
anth-volk marked this pull request as ready for review October 14, 2026 22:11
@anth-volk
anth-volk merged commit 8bfb0fe into main Oct 14, 2026
10 checks passed
@anth-volk
anth-volk deleted the chore/remove-typescript-reader branch October 14, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the unused TypeScript reader package

1 participant