Repository navigation
Remove the unused TypeScript reader package - #16
Merged
Merged
Conversation
@policyengine/microcosm-provider-orrery has no consumer: PolicyEngine/microcosm-runs keeps its own publication reader. Delete typescript/orrery, the root package.json and the reader check and publish scripts, and drop the reader CI job and npm publish job. Releases now version only pyproject.toml and uv.lock and publish only the microcosm-emitter Python distribution to PyPI. The workflow tests pin the remaining job sets, and the diverged-version test becomes a check that the release refuses a missing or duplicated version line. Fixes #15 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
marked this pull request as draft
October 14, 2026 22:00
Contributor
Author
|
Converting to draft; unsure on best repo for TypeScript reader package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
This removes the TypeScript reader
@policyengine/microcosm-provider-orrery, which nothing uses. Its only intended consumer, PolicyEngine/microcosm-runs, keeps its own publication reader (PolicyEngine/microcosm-runs#4 was closed unmerged).The Python distribution
microcosm-emitteris unchanged, including graph publication queueing and upload inmicrocosm_emitter.orrery. It keeps publishing to PyPI through trusted publishing.Changes
typescript/orrery/, the rootpackage.json,tools/check-reader.sh,tools/check-reader-installed.tsandtools/publish-reader.sh.ci.yml: removes thereaderjob and itsorrery-readerartifact.push.yaml: removes thepublish-readerjob, and the header comment now says only PyPI trusts this file. Therequiredcheck inpr.yamldepends only onverify, so it needs no change.tools/bump-version.pyversions onlypyproject.toml.tools/update-version.shstill runs towncrier anduv lock. The comments in it and intools/check-changelog.shnow describe a single version.tests/test_workflows.py:ci.ymlandpush.yamljob sets.versionline inpyproject.toml.README.md: the Publication section now covers PyPI only. The reader paragraph,bash tools/check-reader.shand the reader-checks sentence are gone..gitignore: dropsreader-dist/,typescript/orrery/dist/andnode_modules/. All three were added with the reader.changelog.d/remove-typescript-reader.removed.md.Release
The fragment is
removed, so the version bump is minor. Merging releases 0.3.0, to PyPI only.Validation
I ran these locally in the branch on macOS with Python 3.14:
uv sync --lockeduv lock --checkbash tools/check-quality.shuv run --no-sync pytest -m 'not collector'bash tools/check-artifacts.shbash tools/check-changelog.sh0.2.1 -> 0.3.0uv run --no-project python tools/bump-version.py --check0.3.0and wrote nothingpr.yamlgit grepforprovider-orrery,reader-dist,typescript/,npmandcheck-reader, outsideCHANGELOG.mdanduv.lockI did not run:
collectortests, which need the pinned collector checkout and a disposable PostgreSQL.CI covers both.
This adds no environment variables or secrets. The removed
publish-readerjob used only OIDC. Theversioningjob still readsAPP_IDandAPP_PRIVATE_KEY, which are organisation Actions secrets and unchanged here.After merging
These steps need an npm owner of
@policyengine/microcosm-provider-orreryand are not part of this PR:0.0.0-stage.npm deprecateon every version (0.0.0-stage,0.1.0and0.2.1), pointing to Remove the unused TypeScript reader package #15.push.yaml.🤖 Generated with Claude Code