Repository navigation
Fix review r10's report findings for OP1 - #589
Merged
Merged
Conversation
Review r10 approved #566 at 88b5df2 with one minor finding and four nits, all in op1_report.md: - The r9 table's r8-harness row now separates the ten mutants that gain the property test in every seeded run from the five that gain it on some draws. - The r5 and r6 tables give "7 or 8" and "54 or 55" for the two Hypothesis-dependent cells, and the r9 table names the four counts that vary. - Section 3 words the `git diff --quiet` check unambiguously, names the recount commit and says test modules. - Both timing statements give 8 to 20 s over the author's and reviews r8 to r10's runs. A review r10 section records the verdict and its new mutants. Section 5 states that OP1's exit and harness tests load baselines/asfr.py through the baselines package import, without displaying it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review docs-r1 asked for six phrase-level fixes to 7640fe1: - K30: the property test killed it in none of r10's 20 seeded runs, not "never"; K24's 9 of 20 is likewise r10's count. - The r9 table's r6 row says eight counts have varied with Hypothesis's draws, as the r6 table's ranges show, and names the four in the row of five, A1 included. - K25 and S23 are told apart: S23 differs only for seeds of 2^1203 or more, K25 only for two seeds exactly 2^1203 apart. - The weakening sentence credits the flips and steps past bit 64, and the swap result to the exact-int test's variants. - r10 reproduced every count its brief asked for. - The findings-table row for r10's fourth nit describes the problem correctly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- K25 conflates any two seeds a multiple of 2^1203 apart; within the strategy's range that means exactly 2^1203. - The swap result names the deterministic test it comes from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Landing audit (Microcosm Dynamics coordinator, 2026-10-26 03:59Z). Merged at the reviewed head Gates checked at 03:57Z:
Review: one independent Claude Opus 5.5 check (docs-r1), run in-session because no Subfleet lane was open.
It checked each changed claim against review r10's evidence. This PR closes r10's one minor finding and four nits on #566. |
This was referenced Oct 26, 2026
MaxGhenis
added a commit
that referenced
this pull request
Oct 26, 2026
Master brings OP1 (#566) and its report fix (#589). Git auto-merged scripts/first_estimates_birth_evidence.py and tests/estimates/test_birth_evidence_artifact.py, which both branches changed: the merge keeps master's OP1 lines and SSI0's exclusions and reachability block, and removes no line from either side. tests/tier_counts.json and tests/README-tiers.md conflicted. They now read master's counts plus the SSI0 test modules' 562 tests, counted by collection at this merge: - unit: 547 (contract 20, runner 41, inventory 486) - oracle_policyengine: 15 (engine 11, dataset engine 3, and the static offset test, one unparametrized function, counted from its source) So they read unit 19,327, oracle_policyengine 323 and 25,912 in all; the other tiers are master's. SSI0 adds no test to the birth-evidence module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 26, 2026
MaxGhenis
added a commit
that referenced
this pull request
Oct 26, 2026
Master brings #566 (OP1: the open_population package and its evidence), #589 (OP1's report) and changes to the birth-evidence script and its artifact test. None of it changes the registry module, its two test modules or its mutation specs, and the registry module imports only the standard library and yaml. The tier conflict resolves to master's counts plus this branch's nine unit tests: unit 18,780 + 9 = 18,789, total 25,359. The README tier table matches the tier file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 26, 2026
Master brings #589, #590 and #580: an OP1 report section, a docs ledger, and the held-out registry's module, tests and mutation record. None is a B0.2 file or anything B0.2's script imports. The tier files conflicted. Resolved as master's counts plus this branch's unit delta: 18,789 + 236 = 19,025 unit, total 25,595. The other tiers are unchanged, and the README table matches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 26, 2026
Master brings #566, #589, #590 and #580. Git auto-merged scripts/first_estimates_birth_evidence.py and tests/estimates/test_birth_evidence_artifact.py, which both branches changed: against each parent the merged files only add lines, so the merge keeps master's OP1 exclusions and CE1's exclusions and removes no line from either side. No CE1 path changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only follow-up to #566. It fixes the one minor finding and four nits that delta check r10 left in
docs/design/open_population_evidence/op1_report.mdwhen it approved #566 at88b5df28. No code, test or tier file changes.Head
961f520a:7640fe1cmakes the fixes.5c307826fixes six phrases that independent review docs-r1 found wrong or loose in7640fe1c's new text, and961f520atakes its delta check's two optional nits (see below).What changes in the report
git diff --quietcheck. §3 now says the command prints nothing either way, so its exit status is the check. Before, the sentence could be read as exiting 0 when a file differs.d8302233, and says test modules rather than test files.streams.pymutants r10 tried: five were killed, and the six survivors fall in r9's known classes, which the exact comparison atstreams.py:108rules out.baselines/asfr.pythrough thebaselinespackage, as other test modules on master do, so runs load it without displaying it.Checks
git diff --checkis clean, and the only file changed isop1_report.md.test_exits.py:11,test_harness.py:20–21andstreams.py:108were checked at444f970d.docs/Markdown run in CI.Review docs-r1 (Opus 5.5, at
7640fe1c): REQUEST_CHANGES, fixed in5c307826It found scope clean, all five r10 items fixed as asked, and the new figures exact against r10's seeded runs and the author's run. It asked for six phrase-level fixes:
inttest's variants.docs-r1's delta check (at
5c307826): APPROVE WITH NITS. All six fixes hold. Its two optional nits are taken in961f520a: K25's general case ("a multiple of 2^1203"; this body had said "exactly"), and naming the deterministic test behind the swap result.🤖 Generated with Claude Code