Repository navigation
Track B: keep B2's outcome files out of every blinded review root - #549
Merged
Merged
Conversation
B2's run record (#547) and the attempt ledger (#548) hold reference-year 2012/2014 floor values, truth moments and B2's candidate outcome, and no exposure-inventory scan lists them. A standing exclusion record, docs/design/track_b_b2_outcome_exclusions.json, now names them, and scripts/track_b_b0_1_review_root.py applies every standing record to every build, whatever inventories the build names. A missing record refuses the build rather than dropping it. Tests: 4 new (artifact 4,247 -> 4,251), including a Hypothesis property and an end-to-end build on an invented archive; 3 mutants, all killed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…e union in build() Review round 1 of #549 (both nonblocking): build() now reads every exclusion record before it creates the output, so a missing standing record leaves no partial root; and a build-level test covers a named inventory that repeats a standing path and names a path the archive lacks. 2 more tests (artifact 4,251 -> 4,253); the read-order mutant is killed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Merged at head Gates
Reviews
From this merge on, every blinded review root built by |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR keeps B2's outcome files out of every blinded review root.
B2's run record (#547) and the cumulative attempt ledger (#548) hold reference-year 2012 and 2014 floor values, truth moments and B2's candidate outcome. No exposure-inventory scan lists them, so a root built from
masterwould include them.docs/design/track_b_b2_outcome_exclusions.jsonis a standing exclusion record, in the inventories'q6_exclusionsform. It names five files:runs/track_b_b2_floor.jsonruns/track_b_b2_floor_v1_stopped.jsonruns/track_b_b2_score.jsonruns/track_b_b2_score.attempt.jsonldocs/design/track_b_attempt_ledger.mdscripts/track_b_b0_1_review_root.pygets aSTANDING_EXCLUSIONStuple andstanding_inventories().build()now unions the standing records with whatever--inventoryfiles a builder names, so the guard enforces the exclusion even when a builder forgets it. It reads every exclusion record before it writes anything. A missing standing record therefore refuses the build, rather than dropping silently, and leaves no partial root.The dynamics coordinator added the same paths to the evidence folder's
RESTRICTED-FILES.mdfor blind roles. This PR makes the root builder enforce it.Invariants
FileNotFoundErrorbefore any output exists.Tests
tests/test_track_b_b2_outcome_exclusions.py. They are artifact tier, since the file namesruns/…jsonpaths, so artifact goes from 4,247 to 4,253.test_track_b_b0_1_review_root.py,test_track_b_b0_1_addendum_record.py,test_track_b_b0_1_revision1_tools.pyandtest_track_b_b0_1_audit_record.pygave 310 passed. Black 26.5.1-l 79and ruff are clean.build()ignores the standing records;runs/track_b_b2_score.json;Review round 1 (Astra, job
20261018-142942-trackb-pr549-r1): APPROVE, with no blocking finding. It reran the three original mutants, all killed, and got 307 passed. It skipped one test that opens restricted files. Its two nonblocking suggestions are both taken in00786d79: read the records before writing, and test the union insidebuild().axiom: n/a (review tooling)
🤖 Generated with Claude Code