Repository navigation
Describe the apply gate's exception handling as main's core does - #543
Merged
Merged
Conversation
The comment said the pinned core requires every declared artifact even on a failed gate. That held at microcosm 3ff92b0a. Since #541 the pin is main (c28b4537), where a raising gate is recorded as gate_exception, its artifact is marked unavailable and its consumers are left unreached (executor.py _failed_gate_result). _apply still catches every exception, so dynamics' behaviour is unchanged; only the stated reason moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Merged at reviewed head 7a2c355 (merge commit ed54262) by the dynamics coordinator. Gates: Independent review: GPT-6.1 Sol, Subfleet
This is the follow-up to #541's review (minor finding 1). |
MaxGhenis
added a commit
that referenced
this pull request
Oct 16, 2026
…iers Master gained #525, #534, #538, #543, #544-era changes and #545 since this branch's base (9af5392). Conflicts were the two tier files only; tests/track_u2/test_u2_loader.py, changed on both sides, merged cleanly: the merged file is master's plus exactly this branch's one added test, and this branch's plus exactly master's changes. Every other file equals its one changing side. Tier files rewritten from `pytest --collect-only -q -m <tier>` on the merged tree: unit 9,902, artifact 4,244, integration_psid 1,423, reproduction_legacy 520, oracle_policyengine 308 (16,397), which is master's counts plus this branch's +1 unit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 16, 2026
…iers Master gained #525, #528, #534, #535, #538, #539, #541, #543, #545, since this branch's base (9af5392). Conflicts were the two tier files only; tests/track_u2/test_u2_loader.py, changed on both sides, merged cleanly: the merged file is master's plus exactly this branch's one added test, and this branch's plus exactly master's changes. Every other file equals its one changing side. Tier files rewritten from `pytest --collect-only -q -m <tier>` on the merged tree: unit 9,902, artifact 4,244, integration_psid 1,423, reproduction_legacy 520, oracle_policyengine 308 (16,397), which is master's counts plus this branch's +1 unit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 16, 2026
…iers Master gained #525, #528, #534, #535, #538, #539, #541, #543 and #545 since this branch's base (9af5392). Conflicts were the two tier files only; tests/track_u2/test_u2_loader.py, changed on both sides, merged cleanly: the merged file is master's plus exactly this branch's one added test, and this branch's plus exactly master's changes. Every other file equals its one changing side. Tier files rewritten from `pytest --collect-only -q -m <tier>` on the merged tree: unit 9,902, artifact 4,244, integration_psid 1,423, reproduction_legacy 520, oracle_policyengine 308 (16,397), which is master's counts plus this branch's +1 unit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #541 (minor finding 1 of its review).
The comment at
src/populace_dynamics/graph/trajectory.py:140said the pinned core needs every declared artifact, even when a gate fails. That held at microcosm 3ff92b0a. Since #541 thegraphextra pins microcosm main (c28b4537), which behaves differently. Inpackages/microcosm-graph/src/microcosm/graph/executor.py:_failed_gate_resultrecords an executorgate_exceptionstate and lists the gate's artifact outputs as unavailable._applystill catches every exception and publishes a typedfailedtransition. When the previous transition isn'tcomplete, next year's_applypublishesblocked. So behaviour is unchanged; the change is the comment only.No tests change, so tier counts are unaffected.
🤖 Generated with Claude Code