Repository navigation
Fold the 2026-10-19 StatCan CPI first print: review the 2026_09 strip - #374
Merged
MaxGhenis merged 1 commit intoOct 20, 2026
Merged
Conversation
chronicle#373 (8722b2d, a Thesis resolver append) recorded the 2026-09 first print of statcan.cpi.allitems.yoy as statcan.cpi.allitems.yoy.2026_09.first_print (ledger line 251, period month 2026-09) and merged with Arch checks red: it is the concept's first strip in the source_record_id shape statcan.cpi.allitems.yoy.{P:9999_99}.first_print (the earlier print, line 141, wrote 2026-05 with a hyphen and no suffix). Every pull request into the branch has failed the catalog test since. 2026_09 is the row's own period spelled directly (kind derived), in the segment after the series the row's Thesis registration names, so the strip stands. Same pattern as the reviewed abs.cpi 2026_08 strip. No ledger bytes change; the anchor is unchanged (the append minted and enriched nothing). thesis#377's resolver would have recorded this strip in the append itself: replaying #373 through its catalog_curation gives exactly this entry and an empty residual. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns
codex/thesis-ledger-factsgreen again. It is the same pattern as #363 and #371, and it changes one test fixture only.Why
statcan.cpi.allitems.yoy.2026_09.first_print(ledger line 251, period month 2026-09). It merged with Arch checks red.test_committed_catalog_is_current_and_validreports'2026_09' on 'statcan.cpi.allitems.yoy'as the concept's first strip in thesource_record_idshapestatcan.cpi.allitems.yoy.{P:9999_99}.first_print. The earlier print (line 141) wrote2026-05, with a hyphen and no release-policy suffix.Review of the strip
2026_09is the row's own period spelled directly (kindderived). It is the dataPointId segment after the series named in the row's Thesis registration (records/targets/2026-09-07-30e18f81…).abs.cpi.all_groups.yoy2026_08strip.Anchor
Unchanged. The append minted and enriched nothing, and the registry is untouched.
Verification
uv run pytest tests/test_build_series_catalog.py: 235 passed. On the base tip it failstest_committed_catalog_is_current_and_validwith the message above.scripts/build_series_catalog.py --check: catalog current.Context
ThesisInstitute/thesis#377 (with #372) makes the resolver record provable strips like this one in the append itself. Replaying #373 through its
catalog_curationgives exactly this entry and an empty residual, so this curation PR would not have been needed.🤖 Generated with Claude Code