fix: add aria-label to icon-only buttons and links (#311)#415
Open
fix: add aria-label to icon-only buttons and links (#311)#415
Conversation
Adds accessible labels to interactive elements that only contain icons, making them usable by screen readers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #311
Adds
aria-labelattributes to icon-only interactive elements (buttons and links) soscreen readers can announce their purpose. Also marks a decorative SVG as
aria-hidden.Changes
Icon-only buttons/links (high priority):
APIKey.vue—aria-label="Dismiss"on close button; dynamic:aria-label("Copy API key"/"Copied") on copy buttonTypeaheadSelected.vue—aria-label="Remove"on minus buttonDataSourceMapSidebar.vue—aria-label="Go back"on back button_CourtWarrantMapSidebar.vue—aria-label="Go back"on back buttonModal.vue—aria-label="Close"on X buttonDecorative/supplemental (medium priority):
ZoomableImage.vue—aria-hidden="true"on decorative magnifier SVGindex.vue—aria-label="Terminology definition"on icon-only linkTest plan
npm run test:unit) — all 30 passscreen reader
correct
🤖 Generated with Claude Code