Introduce trainer classes as a first class database entity - #802
Open
Aelysya wants to merge 4 commits into
Open
Conversation
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new database page to manage Trainer classes as true entities rather than text entries, allowing to reduce the amount of duplicate data in the projetc when multiple trainers share a trainer class.
There is also an included fix of the texts shown in the SelectTrainer component that was not correctly updated after a name or class change.
closes #784
Important
This PR will break PSDK loading process without the necessary update
Related PSDK PR: https://gitlab.com/pokemonsdk/pokemonsdk/-/merge_requests/1881
Note before testing
Open your project outside of this PR's branch to prepare it.
In the trainers page, add at least two new trainers to test the de-duplication system of the migration. One should have a trainer class that is an exact copy of another existing one (across all languages). The other should only have a change in one of the languages (same name in english, different in french for example)
Save the project and switch to this PR's branch to continue the tests.
Tests to perform