Add missing fossils for gen iv

[Machine-Maker]

Change description

• Closes Gen IV fossils seem to be missing from encounter data #1475
• Added all fossils for Gen IV games (all 5).
• Added 2 new location areas, the museums in the 2 regions
• Added 2 new encounter condition values for the 2 fossil items that didn't exist.

AI coding assistance disclosure

Used claude code to analyze the csv files to help me understand the structure and identify ids of existing elements to re-uses.

Contributor check list

• I have written a description of the contribution and explained its motivation.
• I have written tests for my code changes (if applicable).
• I have read and understood the AI Assisted Contribution guidelines.
• I will own this change in production, and I am prepared to fix any bugs caused by my code change.

[Naramsim]

Hi! To me it looks fine but I didn't check the data/v2/csv/encounter_condition_value_map.csv and data/v2/csv/encounters.csv file. If @notblisy or @ItsMeJoji have some time maybe they could help us here

[jemarq04]

I think some IDs got swapped around as the encounter conditions don't match the Pokemon (e.g. Aerodactyl has item-skull-fossil instead of item-old-amber).

I'll do a review once that's been fixed, but @notblisy and @ItsMeJoji please add on as well if you have any comments

[ItsMeJoji]

I think some IDs got swapped around as the encounter conditions don't match the Pokemon (e.g. Aerodactyl has item-skull-fossil instead of item-old-amber).

I'll do a review once that's been fixed, but @notblisy and @ItsMeJoji please add on as well if you have any comments

Looks like the changes in the encounter_value_condition_map.csv seeped into existing encounter_ids.

Take the first few:
71742,46
71743,47
71744,48

These are encounters for Feebas, but were reassigned to the Dome, Helix, and Amber Fossils' values from encounter_condition_values.csv.

After the fork is resynced, we should check that no previous data is affected, like it was here.

[jemarq04]

Great catch, I usually don't look for potential overwrites in the PR

[Machine-Maker]

Ok, merged latest master into my branch shifting down IDs.

[jemarq04]

Looks good to me!

[Machine-Maker]

I should've done these one at a time... just creating massive headaches resolving conflicts after merging one in... Lesson learned.

[jemarq04]

Hahaha yes, I had forgotten to suggest that during this review. notblisy has made a lot of contributions to encounters lately, but spacing them out one by one is important to avoid the headaches with all the merge conflicts you'll give yourself!