Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 5.94 % | 3.826e+03 | 4.053e+03 | 227.34 | 39.46 | 36.44 |
test_proximal_jac_w7x_with_eq_update | -0.22 % | 6.493e+03 | 6.479e+03 | -14.16 | 162.81 | 160.60 |
test_proximal_freeb_jac | -0.09 % | 1.321e+04 | 1.320e+04 | -11.76 | 84.51 | 82.10 |
test_proximal_freeb_jac_blocked | -0.67 % | 7.528e+03 | 7.478e+03 | -50.43 | 73.78 | 73.06 |
test_proximal_freeb_jac_batched | 0.52 % | 7.451e+03 | 7.490e+03 | 38.51 | 73.08 | 72.86 |
test_proximal_jac_ripple | -4.61 % | 3.531e+03 | 3.368e+03 | -162.74 | 62.58 | 65.67 |
test_proximal_jac_ripple_bounce1d | -0.35 % | 3.583e+03 | 3.570e+03 | -12.63 | 74.62 | 76.51 |
test_eq_solve | 1.29 % | 1.992e+03 | 2.017e+03 | 25.64 | 94.31 | 94.11 |For the memory plots, go to the summary of |
f0uriest
previously requested changes
Sep 19, 2025
a6d949b to
d685405
Compare
unalmis
commented
Sep 22, 2025
unalmis
commented
Sep 22, 2025
Collaborator
Author
Yes, and I have resolved your other comments concerning cosmetics in the code comments. |
When drafting a reply to a reviewer comment, I realized that the atomic derivative computed by the autodiff tool for the `spline=True` option is not correct if the bounce point lies near a local maxima. The `spline=False` option is fine. It is unlikely this would have affected optimization. See section 3 of [autodiff.pdf](https://github.com/user-attachments/files/24988182/autodiff.pdf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inverse stream maps
Yparameter for Heliotron (NFP=19) in effective ripple tutorial #1928 and increases default objective resolution forY_B.Other performance improvements
low_rammode which is same speed and less memory forobjective.compute, but slower forobjective.gradsince JAX is poor at iterative algorithms.interp_to_argminforBounce2Dfrom h^4 to spectral.Usability
kwargsas was needed for my article.interpax#1388.Bugs
test_compute_everything.Benchmarks
Just go to #2026 and run
effective_ripple_profile.py. You will see the large performance improvement frommaster. The CI benchmarks do not reveal this because those benchmarks are essentially just noise. Note that, using the same parameter inputs, the resolution of this branch is also higher thanmasterdue to the faster convergence.use_bounce1d=Trueon that script, you will run out of memory as expected since it is an inferior approach (as expected, you get the OOM in the jacobian before you compute a single bounce integral).nufft_eps=0, you need 175 GB to run that script onmaster(you'll get an OOM and JAX will tell you it needs 175GB), but only 35 GB on this branch.Examples
HELIOTRON
MasterbranchThis branch
W7-X
MasterbranchThis branch
NCSX
MasterbranchThis branch
Removal of spectral aliasing