Merged
Conversation
causes UI confusion
balen
changed the title
Gailbear
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table shows ”Showing 21 to 40 of 71 (83 total records)”
Because there are 71 sent mailings + 12 draft. The table only shows the sent mailings (but there are 83 mailing records in the DB because of the drafts)
We have the number of total records in the generic table component to show the total if there were no filters (e.g. in advanced search). So we should suppress it in such cases as these because it is misleading.
Code changed to allow a default filter seperately