Refactor block dropping when breaking block with a tool - #3533
Open
DellieDelta wants to merge 15 commits into
Open
Refactor block dropping when breaking block with a tool#3533DellieDelta wants to merge 15 commits into
DellieDelta wants to merge 15 commits into
Conversation
IntegratedQuantum
requested changes
Aug 20, 2026
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
Member
There was a problem hiding this comment.
I don't think this is the right place for this functionality. blocks.zig is already a big file and so far it has mostly definitions of block properties and loading/access thereof, but little functionality (and all functions on Block are retrieving properties, none are actually doing things).
In the issue I proposed to move them to the server world, which is also maybe a bit too big right now.
So maybe the BlockDrop struct deserves its own file (and in server, since blockdrops are not done on the client). And all the helper structs and functions (including #3532) could be defined there.
Contributor
Author
|
I agree. I'll make a new PR for moving |
DellieDelta
marked this pull request as draft
August 20, 2026 16:12
IntegratedQuantum
pushed a commit
that referenced
this pull request
Aug 20, 2026
DellieDelta
force-pushed
the
with-item-blockdrop-refactor
branch
from
August 20, 2026 18:15
369b410 to
c54395f
Compare
DellieDelta
marked this pull request as ready for review
August 20, 2026 18:30
DellieDelta
marked this pull request as draft
August 20, 2026 18:31
DellieDelta
marked this pull request as ready for review
August 20, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3532
Progress towards #2385