Skip to content

adds sound effects for sound effect pr - #39

Closed
Crepestrom wants to merge 9 commits into
PixelGuys:masterfrom
Crepestrom:starter-sound-effects
Closed

Crepestrom wants to merge 9 commits into
PixelGuys:masterfrom
Crepestrom:starter-sound-effects

Conversation

@Crepestrom

Copy link
Copy Markdown

for PixelGuys/Cubyz#3626 or similar

@Wunka Wunka moved this to Waiting for artistic review in PRs to review Sep 27, 2026
@IntegratedQuantum

Copy link
Copy Markdown
Member

@careeoki @ikabod-kee

@careeoki careeoki left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will be fine for now.

@ikabod-kee

Copy link
Copy Markdown
Contributor

Yes, this shall do.

@ikabod-kee

Copy link
Copy Markdown
Contributor

Later on we will have to organize the sounds into seperate folders, for organization purposes :P

@IntegratedQuantum IntegratedQuantum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the release script to include assets from this new folder.

@IntegratedQuantum IntegratedQuantum moved this from Easy to Review to In review in PRs to review Oct 9, 2026

@IntegratedQuantum IntegratedQuantum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing to think about with the folder structure: How do you plan to handle variants? e.g. we probably want multiple variants of jumping sounds that are selected at random.

@Crepestrom

Crepestrom commented Oct 23, 2026 •

Copy link
Copy Markdown
Author

sounds will be broken up into 3 layers
material/type/variation
eg:
metal/break/0

@IntegratedQuantum

Copy link
Copy Markdown
Member

Why not put these first sounds already into this structure?

@Crepestrom

Copy link
Copy Markdown
Author

good point
ill do that in a minute

@Crepestrom

Crepestrom commented Oct 23, 2026 •

Copy link
Copy Markdown
Author

alright moved over

@Crepestrom

Copy link
Copy Markdown
Author

can someone else make my sound effect assets pr
something weird has gone wrong and i dont know how to fix this and aparently its too difficult to fix on windows

@Crepestrom Crepestrom closed this Oct 23, 2026
@Crepestrom Crepestrom mentioned this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants