Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
MET-543 documents explicit successful and error response schemas for usage, timeseries, environments and calls.
How It Works
Schema-only FastAPI response declarations preserve existing values and auth. Required and nullable fields, units, filters, completeness and call cursor semantics are explicit. Environment values include null for untagged records; future additive metadata remains allowed. See docs/operations/telemetry-read-contracts.md.
Stack parent: MET-550 #93, commit c84a3ed. The shared application has a separate draft; consumers need no payload migration, and MET-545 owns final packaged rolling-release checks.
QA Overview
880 core/server tests passed with disposable PostgreSQL (one existing dependency warning); focused schema tests 26 passed; new-module/test Ruff passed. Actual HTTP responses validated against this build's served schemas, including nonempty/null fields, untagged environment choices, cursor pages, auth/query/validation errors and a real five-second lock timeout with recovery.
Final independent Claude review found no actionable findings after correcting its null-environment schema/coverage findings. No runtime output filtering, UI change, migration or provider calls. OSS has no operational metrics exporter; no throughput or hosted/installed fleet claim. Draft only, test services cleaned up.