fix: stop polling cancelled Browser Use runs - #1
Open
MagMueller wants to merge 1 commit into
Open
MagMueller wants to merge 1 commit into
MagMueller wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop polling when Browser Use V4 reports cancelled. Keep the existing completed/failed scoring set unchanged, and have the benchmark runner report cancellation as an infrastructure error so the task remains excluded from benchmark scoring.
Verified through the existing urllib transport against a synthetic localhost HTTP server. Before the patch, cancelled responses trigger repeated GETs until timeout; after it, cancelled, completed and failed responses each return after one request. The real benchmark runner's cancelled path remains unscored.
Ran the full test suite and verified every frozen gold-evidence anchor on Python 3.12. No hosted benchmark, real credential, browser or model was used. Default polling intervals and timeouts are unchanged.