Repository navigation
ci(governance): remove the dead shadow gate and duplicate secret scan - #38
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Qoder Agent authored this change while executing the owner-approved P0 governance cleanup plan for this repository. Review is Codex: the risk gate on this repository only counts a Codex review receipt written against the current head commit, and Codex is the reviewer relied on here. No human owner review is claimed by this pull request.
What changed
.github/workflows/review-gate.yml. It calledQuantStrategyLab/.github/.github/workflows/governance-acceptance.yml@a267ab46389b19c88e552efe64f8f9b1cc7753ffinSHADOWmode, and that shadow engine no longer exists, so the job could only ever fail or report on nothing..github/workflows/required-gitleaks.yml. Itssecret-scanjob called the sharedgitleaks.ymlreusable workflow and duplicated theGitleaksjob that.github/workflows/engineering-governance.ymlalready runs on every pull request and push tomain.weekly-gitleaks.ymlis kept because it is the only scheduled full-history scan.The change is limited to removing dead or duplicated governance workflows. No application code, test, documentation, or other business file is touched.
How verified
gh api repos/Pigbibi/TelegramAutoSignBot/branches/main/protectionconfirmedGitleaksstays required and the duplicateSecret scan / Gitleakscontext was removed before this pull request was opened, so deletingrequired-gitleaks.ymlcannot leave a required check with no producer.grep -rn "required-gitleaks" . --exclude-dir=.gitmatched only the file being deleted, so nothing else referenced it.grep -n "^ gitleaks:" .github/workflows/engineering-governance.ymlreports the survivingGitleaksjob that still scans pull request commits.grep -rn "review-gate" . --exclude-dir=.gitbefore the change matched only.github/workflows/review-gate.ymlitself, so no workflow, script, or test depended on the file.git show --stat HEADshows 2 files changed, 33 deletions(-).gh api repos/Pigbibi/TelegramAutoSignBot/branches/main/protectionafter the change reportsstrict=true,enforce_admins=true, and the required contextsRepository hygiene, risk-gate, pr-template, Gitleaks.Required checks that run on this pull request:
Repository hygiene(workflow safety checks plus actionlint),Gitleaks(thegitleaksjob inengineering-governance.yml, which scans the pull request commits),Commit message convention,risk-gateandpr-template.Privacy, permissions or data flow
No secret, credential, token, or user data is added, moved, or exposed. The removed workflows both declared read-only permissions, so no privilege is gained or lost by deleting them. Secret scanning coverage is unchanged: the
Gitleaksjob inengineering-governance.ymlstill scans every pull request, andweekly-gitleaks.ymlstill runs the scheduled full-history scan. Removing the shadow job also stops this repository from sending pull request metadata to a deleted workflow definition in another organisation's repository.Related issue
There is no separate tracking issue. This pull request is one item of the P0 governance cleanup plan approved by the repository owner, covering the removal of the dead shadow review gate and the duplicate required secret scan.