Skip to content

Feat/pwa manifest icons#435

Merged
Junman140 merged 2 commits into
Pi-Defi-world:devfrom
oncleweynom:feat/pwa-manifest-icons
May 29, 2026
Merged

Feat/pwa manifest icons#435
Junman140 merged 2 commits into
Pi-Defi-world:devfrom
oncleweynom:feat/pwa-manifest-icons

Conversation

@oncleweynom
Copy link
Copy Markdown

Added PWA manifest with 192px and 512px icons so Android's "Add to Home Screen" prompt works. Includes the manifest route, rasterized icons from the existing SVG, CSP update, and a build-time icon generation script.
closes #338

Aframp Dev added 2 commits May 28, 2026 14:44
- Add isRTL(), getDir(), RTL_LOCALES to lib/i18n/index.ts
- Sync <html dir> and <html lang> on locale change via I18nProvider
- Set dir='ltr' SSR default in app/layout.tsx
- Flip BackButton arrow icon with rtl:rotate-180
- Fix sheet, toast, dialog, alert-dialog close button positions
- Fix select, dropdown-menu, context-menu, menubar indicator padding
- Fix table text-left alignment and checkbox padding
- Fix pagination chevron icons and directional padding
- Fix drawer/dialog header text alignment
- Fix sidebar menu badge position
- Add .icon-directional, .numeric, page-header-row RTL utilities to globals.css
- Add app/manifest.ts (Next.js native manifest route) with name,
  short_name, start_url, display standalone, theme/background colors,
  and 192px maskable + 512px any icons
- Generate public/icons/icon-192.png and icon-512.png from icon.svg
  via scripts/generate-pwa-icons.mjs (uses sharp)
- Wire manifest into layout metadata and add adaptive theme-color
  meta tags (light: #ffffff, dark: #1a0a2e)
- Add manifest-src 'self' to CSP in middleware.ts
- Add generate:icons script and prepend icon generation to build step
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Warning

Review limit reached

@oncleweynom, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 36 minutes and 2 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f9042107-436f-42a8-8f27-94bd1a30d65a

📥 Commits

Reviewing files that changed from the base of the PR and between 2a07e07 and b0b710b.

⛔ Files ignored due to path filters (2)
  • public/icons/icon-192.png is excluded by !**/*.png
  • public/icons/icon-512.png is excluded by !**/*.png
📒 Files selected for processing (21)
  • app/globals.css
  • app/layout.tsx
  • app/manifest.ts
  • components/navigation/BackButton.tsx
  • components/ui/alert-dialog.tsx
  • components/ui/context-menu.tsx
  • components/ui/dialog.tsx
  • components/ui/drawer.tsx
  • components/ui/dropdown-menu.tsx
  • components/ui/menubar.tsx
  • components/ui/pagination.tsx
  • components/ui/select.tsx
  • components/ui/sheet.tsx
  • components/ui/sidebar.tsx
  • components/ui/table.tsx
  • components/ui/toast.tsx
  • contexts/i18n-context.tsx
  • lib/i18n/index.ts
  • middleware.ts
  • package.json
  • scripts/generate-pwa-icons.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 28, 2026

@oncleweynom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Junman140 Junman140 merged commit 8b1c4d1 into Pi-Defi-world:dev May 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Favicon and PWA manifest missing or incomplete – L

2 participants