fix: add missing --app argument to executor tasks subparser#32
Merged
santanusinha merged 1 commit intoJul 8, 2026
Merged
Conversation
The show_tasks() method in executors.py references options.app to filter tasks by source app name, but the tasks subparser never defines the --app argument. This causes an AttributeError when any tasks exist on the executor. Changes: - Add --app/-a argument to executor tasks subparser (matching tasks.py) - Add task seed data to mock server so tests exercise the code path - Add 3 offline tests for executor tasks with --app filtering
santanusinha
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
drove executor tasks <executor-id>crashes withAttributeError: 'Namespace' object has no attribute 'app'when any tasks exist on the executor.Root cause:
plugins/executors.pyline 125 referencesoptions.appto filter tasks by source app, but thetaskssubparser (lines 35-39) never defines the--appargument. Thedrove tasks listcommand inplugins/tasks.pycorrectly defines this argument.The existing test (
test_executor_tasks_succeeds) didn't catch this because the mock server's executor had an empty tasks list, so the buggy code path was never reached.Fix
--app/-aargument to theexecutor taskssubparser, matching the pattern inplugins/tasks.pytests/mock_server.pyTesting
All offline tests pass (
pytest -m offline):test_executor_tasks_shows_task_data- verifies tasks are displayed when presenttest_executor_tasks_app_filter_shows_match- verifies--appshows matching taskstest_executor_tasks_app_filter_excludes_nonmatch- verifies--apphides non-matching tasks