Make APRX hear outgoing packets on ax25 ports#81
Open
tvrusso wants to merge 1 commit into
Open
Conversation
APRX set the protocol for the ax25 receive socket to ETH_P_AX25. This was done to prevent non-AX25 packets from coming in on the socket. It was put in in commit 395fbdf back in 2007. The use of ETH_P_AX25 assured that non-AX25 packets were ignored, but it predated other code implemented in commit ff8fd51 just two years later, that filtered out a lot of uninteresting packets. This commit reinstates use of ETH_P_ALL and expands the filtering to accept outgoing packets. If the AX.25 port is shared by aprx and other aprs programs, aprx now sees the packets transmitted by those other programs an gates or digipeats them appropriately. Previously, those packets would only be seen by aprx if they were digipeated by another station and heard on our receive ports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APRX set the protocol for the ax25 receive socket to ETH_P_AX25. This was done to prevent non-AX25 packets from coming in on the socket. It was put in in commit 395fbdf back in 2007.
The use of ETH_P_AX25 assured that non-AX25 packets were ignored, but it predated other code implemented in commit ff8fd51 just two years later, that filtered out a lot of uninteresting packets.
This commit reinstates use of ETH_P_ALL and expands the filtering to accept outgoing packets.
If the AX.25 port is shared by aprx and other aprs programs (as they are at my station), aprx now sees the packets transmitted by those other programs and gates or digipeats them appropriately. Previously, those packets would only be seen by aprx if they were digipeated by another station and heard on our receive ports.