Skip to content

Fix 'Show' on bad self error for embedded tooltips #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptarjan wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Fix 'Show' on bad self error for embedded tooltips #374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4378788
Fix 'Show' on bad self error for embedded tooltips
Mar 21, 2026
a192dd5
Use pcall for tooltip:Show() instead of GameTooltip filter
Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/GameTooltip_Core.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ do
end

if self.anyChange then
tooltip:Show();
pcall(tooltip.Show, tooltip);
end

if self.hasAltMode then
Expand Down