Skip to content

fix(runtime): typed-array own-property fallback shadows secret-key buffer metadata (#4363 regression) #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Jun 4, 2026
+9 −1
Merged

fix(runtime): typed-array own-property fallback shadows secret-key buffer metadata (#4363 regression) #4399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/perry-runtime/src/object/field_get_set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2099,7 +2099,15 @@ pub extern "C" fn js_object_get_field_by_name(
}
}
}
return JSValue::undefined();
// #4363 regression fix: a secret-key Uint8Array (KeyObject backing
// buffer) exposes `type` / `symmetricKeySize` / `asymmetricKey*`
// through the KeyObject metadata block later in this function. The
// typed-array own-property fallback must not shadow those with
// `undefined` — fall through for a secret-key buffer so the metadata
// block resolves them. Plain typed arrays keep the `undefined` result.
if !crate::buffer::is_secret_key(addr) {
return JSValue::undefined();
}
}
// #2128: a plain JS number value (a finite double or canonical NaN —
// anything `JSValue::is_number` returns true for *minus* the raw-I64
Expand Down
Loading