[codex] build http ext archive for no-auto HTTP-family parity#4277
Draft
andrewtdiz wants to merge 2 commits into
Draft
[codex] build http ext archive for no-auto HTTP-family parity#4277andrewtdiz wants to merge 2 commits into
andrewtdiz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perry-ext-httpand the matching stdlib external HTTP pump features for no-auto node-suite HTTP-family runsAgentandClientRequesthandle dispatch when no-auto links full stdlib ahead of the ext HTTP archiveRoot Cause
The no-auto path consumes prebuilt full-stdlib archives plus well-known ext archives. The runner built the ext HTTP archive, but not the stdlib HTTP pump features, so ext HTTP server/client handle queues were not fully integrated into the event loop. In the HTTPS client surface, full stdlib also owns several
https.Agent/ClientRequesthelpers, so stdlib direct/generic dispatch needed to recognize ext ClientRequest handles and stdlib Agent handles.Validation
PERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module https'(3 pass, 0 compile fail)PERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module http2'(8 pass, 0 compile fail)cargo check -p perry-stdlib -p perry-hir -p perry-ext-http --features perry-stdlib/external-http-server-pump,perry-stdlib/external-http-client-pumpcargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shFixes #4275.
Covers the HTTPS no-auto compile/surface slice under #2132.