[codex] Fix Object.prototype.toString brands for functions and namespaces#4269
Merged
proggeramlug merged 1 commit intoJun 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #3986.
This fixes
Object.prototype.toString.call(value)branding for callable values and the built-in namespace objects covered by Node:[object Function]before the numeric fallbackSymbol.toStringTagvalues forMath,JSON, andReflect{ writable: false, enumerable: false, configurable: true }Root Cause
Perry's canonical object-to-string helper did not recognize closure-backed functions or class values before falling through to generic object/number branding. The
Math,JSON, andReflectnamespace objects also had reflected members but no intrinsicSymbol.toStringTag, so the default tag stayed[object Object].Validation
mainplus the new fixture failed withordinary: [object Object]where Node reports[object Function]PERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc 'node --version; ./run_parity_tests.sh --suite node-suite --module globals --filter object-tostring-brands'PERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc 'node --version; ./run_parity_tests.sh --suite node-suite --module globals --filter builtin-namespace'PERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc 'node --version; ./run_parity_tests.sh --suite node-suite --module globals --filter function-tostring'CARGO_TARGET_DIR=/tmp/perry-object-tostring-check cargo check -p perry-runtimecargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh