[WIP #46] fix : Fix local startup error#50
Open
DearZh wants to merge 2 commits intoPerfMa:iteration/2.1.xfrom
Open
[WIP #46] fix : Fix local startup error#50DearZh wants to merge 2 commits intoPerfMa:iteration/2.1.xfrom
DearZh wants to merge 2 commits intoPerfMa:iteration/2.1.xfrom
Conversation
1、local startup load tools.jar 2、local startup load SystemCommand 3、modify module version
ferdiknight
reviewed
Mar 7, 2023
| } | ||
|
|
||
| public static String getXpocketScrollPath() { | ||
| return System.getProperty(SCROLL_PATH, System.getProperty(HOME_NAME) + File.separator + "scrolls" + File.separator); |
Contributor
There was a problem hiding this comment.
这里有切实必要从常量变实时调用不，差异在于，常量是初始化时调用一次就确定了，后续只是取值；实时调用意味着每次执行都会做一次map查询
Contributor
Author
There was a problem hiding this comment.
这里有切实必要从常量变实时调用不，差异在于，常量是初始化时调用一次就确定了，后续只是取值；实时调用意味着每次执行都会做一次map查询
的确没有实时获取最新SCROLL_PATH的必要，已调整
This was
linked to
issues
Mar 7, 2023
ferdiknight
reviewed
Mar 27, 2023
| }); | ||
|
|
||
| File dir = new File(XPocketConstants.getXpocketScrollPath()); | ||
| File[] files = dir.listFiles((dir1, name) -> name.endsWith("scl")); |
Contributor
There was a problem hiding this comment.
使用stream语法需要考虑jdk兼容性 （虽然目前没做jdk6的兼容，不过其实是有一定考虑的
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1、local startup load tools.jar
2、local startup load SystemCommand
3、modify module version