Clean up newlines a bit

CMakeLists.txt

@@ -19,7 +19,6 @@ if(WITH_ASAN)
   endif()
 endif()
 
-
 add_subdirectory(kmipcore)
 add_subdirectory(kmipclient)
 

kmipclient/CHANGELOG.md

@@ -14,4 +14,3 @@ Dec, 2025 Version 0.1.1
 Apr, 2025 Version 0.1.0
 
     Initial implementation of all functionality available in "kmippp"
-

kmipclient/README.md

@@ -839,4 +839,3 @@ connection parameters:
 ```
 example_get_tls_verify <host> <port> <client_cert> <client_key> <server_ca_cert> <key_id> <mode: strict, no-hostname, insecure>
 ```
-

kmipclient/TODO.md

@@ -14,5 +14,3 @@ The list of things yet to be done
 6. Version negotiation with the KMIP server (Default is 1.4)
 7. Complete version 2.0 specification support in the scope of current functionality.
 8. Additional security features like optional certificates verification, client authentication, etc.
-
-

kmipclient/include/kmipclient/KeyBase.hpp

@@ -93,6 +93,7 @@ namespace kmipclient {
     /** @brief Build protocol-level representation from the client key object.
      */
     [[nodiscard]] kmipcore::Key to_core_key() const;
+
     /** @brief Build the corresponding client key subclass from protocol-level
      * data. */
     [[nodiscard]] static std::unique_ptr<Key>

kmipclient/include/kmipclient/Kmip.hpp

@@ -7,13 +7,15 @@
 
 #ifndef KMIP_HPP
 #define KMIP_HPP
+
 #include "kmipclient/KmipClient.hpp"
 #include "kmipclient/NetClientOpenSSL.hpp"
 #include "kmipcore/kmip_protocol.hpp"
 
 #include <memory>
 
 namespace kmipclient {
+
   /**
    * @brief Convenience wrapper that owns transport and client instances.
    *
@@ -167,5 +169,7 @@ namespace kmipclient {
     /** @brief High-level KMIP protocol client bound to @ref m_net_client. */
     KmipClient m_client;
   };
+
 }  // namespace kmipclient
+
 #endif  // KMIP_HPP

kmipclient/include/kmipclient/KmipClient.hpp

@@ -130,7 +130,6 @@ namespace kmipclient {
         const std::string &name, const std::string &group, const Secret &secret
     ) const;
 
-
     /**
      * @brief Executes KMIP Create to generate a server-side AES key.
      * @param name Value of the KMIP "Name" attribute.
@@ -209,7 +208,6 @@ namespace kmipclient {
     [[nodiscard]] std::vector<std::string>
         op_locate_by_name(const std::string &name, object_type o_type) const;
 
-
     /**
      * @brief Executes KMIP Locate using the object group filter.
      * @param group Group name to match.
@@ -246,7 +244,6 @@ namespace kmipclient {
         std::optional<std::size_t> *located_items = nullptr
     ) const;
 
-
     /**
      * @brief Executes KMIP Revoke for a managed object.
      * @param id Unique identifier of the object to revoke.
@@ -263,6 +260,7 @@ namespace kmipclient {
         const std::string &message,
         time_t occurrence_time
     ) const;
+
     /**
      * @brief Executes KMIP Destroy for a managed object.
      * @param id Unique identifier of the object to destroy.
@@ -305,7 +303,6 @@ namespace kmipclient {
         std::optional<std::size_t> *located_items = nullptr
     ) const;
 
-
     /**
      * @brief Executes KMIP Discover Versions to query supported protocol
      * versions.
@@ -367,7 +364,6 @@ namespace kmipclient {
       return close_on_destroy_;
     }
 
-
   private:
     NetClient *net_client = nullptr;
     std::shared_ptr<NetClient> net_client_owner_;
@@ -381,4 +377,5 @@ namespace kmipclient {
   };
 
 }  // namespace kmipclient
+
 #endif  // KMIP_CLIENT_HPP

kmipclient/include/kmipclient/KmipClientPool.hpp

@@ -62,11 +62,13 @@ namespace kmipclient {
   public:
     // ---- Constants
     // -------------------------------------------------------------
+
     /** Default upper bound for simultaneously open KMIP connections. */
     static constexpr size_t DEFAULT_MAX_CONNECTIONS = 16;
 
     // ---- Config
     // ----------------------------------------------------------------
+
     /**
      * @brief Connection and pooling settings used to construct @ref
      * KmipClientPool.
@@ -95,6 +97,7 @@ namespace kmipclient {
 
     // ---- BorrowedClient
     // --------------------------------------------------------
+
     /**
      * RAII guard wrapping a single borrowed connection.
      *

kmipclient/include/kmipclient/NetClient.hpp

@@ -14,6 +14,7 @@
 #include <string>
 
 namespace kmipclient {
+
   /**
    * @brief Abstract transport interface used by @ref KmipClient.
    *
@@ -68,12 +69,12 @@ namespace kmipclient {
     virtual NetClient &operator=(const NetClient &) = delete;
     NetClient(NetClient &&) = delete;
     virtual NetClient &operator=(NetClient &&) = delete;
+
     /**
      * @brief Establishes network/TLS connection to the KMIP server.
      *        Must honor @ref m_timeout_ms for connect + handshake phases.
      * @return true on successful connection establishment, false otherwise.
      */
-
     virtual bool connect() = 0;
     /** @brief Closes the connection and releases underlying resources. */
     virtual void close() = 0;
@@ -101,6 +102,7 @@ namespace kmipclient {
      * @return true when connected, false otherwise.
      */
     [[nodiscard]] bool is_connected() const noexcept { return m_isConnected; }
+
     /**
      * @brief Sends bytes over the established connection.
      * @param data Source buffer.
@@ -125,5 +127,7 @@ namespace kmipclient {
     TlsVerificationOptions m_tls_verification{};
     std::atomic<bool> m_isConnected{false};
   };
+
 }  // namespace kmipclient
+
 #endif  // KMIP_NET_CLIENT_HPP

kmipclient/include/kmipclient/NetClientOpenSSL.hpp

@@ -20,6 +20,7 @@ void BIO_free_all(BIO *);
 }
 
 namespace kmipclient {
+
   /**
    * @brief OpenSSL BIO-based implementation of @ref NetClient.
    */
@@ -96,6 +97,7 @@ namespace kmipclient {
 
     bool checkConnected();
   };
+
 }  // namespace kmipclient
 
 #endif  // KMIPNETCLILENTOPENSSL_HPP

kmipclient/src/IOUtils.cpp

@@ -118,7 +118,6 @@ namespace kmipclient {
         )
     );
 
-
     return response;
   }
 

kmipclient/src/KmipClient.cpp

@@ -196,7 +196,6 @@ namespace kmipclient {
         .getUniqueIdentifier();
   }
 
-
   std::string KmipClient::op_create_aes_key(
       const std::string &name,
       const std::string &group,

kmipclient/src/PrivateKey.cpp

@@ -9,7 +9,6 @@
 
 namespace kmipclient {
 
-
   std::unique_ptr<Key> PrivateKey::clone() const {
     return std::make_unique<PrivateKey>(*this);
   }

kmipclient/src/PublicKey.cpp

@@ -9,7 +9,6 @@
 
 namespace kmipclient {
 
-
   std::unique_ptr<Key> PublicKey::clone() const {
     return std::make_unique<PublicKey>(*this);
   }

kmipclient/src/StringUtils.cpp

@@ -12,6 +12,7 @@
 #include <array>
 #include <string_view>
 #include <vector>
+
 namespace kmipclient {
 
   unsigned char char2int(const char input) {
@@ -74,5 +75,4 @@ namespace kmipclient {
     return out;
   }
 
-
-}  // namespace kmipclient
+}  // namespace kmipclient

kmipclient/src/SymmetricKey.cpp

@@ -44,7 +44,6 @@ namespace kmipclient {
 
   }  // anonymous namespace
 
-
   std::unique_ptr<Key> SymmetricKey::clone() const {
     return std::make_unique<SymmetricKey>(*this);
   }

kmipclient/src/X509Certificate.cpp

@@ -9,7 +9,6 @@
 
 namespace kmipclient {
 
-
   std::unique_ptr<Key> X509Certificate::clone() const {
     return std::make_unique<X509Certificate>(*this);
   }

kmipclient/tests/KmipClientIntegrationTest.cpp

@@ -27,10 +27,8 @@
 
 using namespace kmipclient;
 
-
 static std::string TESTING_NAME_PREFIX = "tests_";
 
-
 // Helper class to manage environment variables
 class KmipTestConfig {
 public:

kmipclient/tests/KmipClientPoolIntegrationTest.cpp

@@ -289,7 +289,6 @@ TEST_F(KmipClientPoolIntegrationTest, PoolCreateAndGet) {
   }
 }
 
-
 // ============================================================================
 // Concurrent Operations Tests
 // ============================================================================

kmipcore/CMakeLists.txt

@@ -5,7 +5,6 @@ project(kmipcore LANGUAGES CXX)
 set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
-
 file(GLOB_RECURSE SOURCES CONFIGURE_DEPENDS "src/*.cpp")
 file(GLOB_RECURSE HEADERS CONFIGURE_DEPENDS "include/kmipcore/*.hpp")
 

kmipcore/include/kmipcore/kmip_basics.hpp

@@ -17,7 +17,6 @@
 #include <variant>
 #include <vector>
 
-
 namespace kmipcore {
 
   // Forward declaration for SerializationBuffer
@@ -201,7 +200,6 @@ namespace kmipcore {
     [[nodiscard]] uint32_t toInterval() const;
   };
 
-
 }  // namespace kmipcore
 
 #endif /* KMIPCORE_KMIP_BASICS_HPP */

kmipcore/include/kmipcore/kmip_enums.hpp

@@ -58,7 +58,6 @@ namespace kmipcore {
   /** Generic sentinel value representing unset enum/int fields. */
   inline constexpr std::int32_t KMIP_UNSET = -1;
 
-
   inline constexpr std::int32_t KMIP_OK = 0;
   inline constexpr std::int32_t KMIP_NOT_IMPLEMENTED = -1;
   inline constexpr std::int32_t KMIP_ERROR_BUFFER_FULL = -2;
@@ -376,7 +375,6 @@ namespace kmipcore {
     KMIP_WRAPTYPE_AS_REGISTERED = 0x02
   };
 
-
   enum class mask_generator : std::uint32_t {
     // KMIP 1.4
     KMIP_MASKGEN_MGF1 = 0x01
@@ -2540,7 +2538,6 @@ namespace kmipcore {
   inline constexpr std::uint32_t KMIP_SECDATA_EXTENSIONS =
       static_cast<std::uint32_t>(secret_data_type::KMIP_SECDATA_EXTENSIONS);
 
-
 }  // namespace kmipcore
 
 #endif  // KMIPCORE_KMIP_ENUMS_HPP

kmipcore/include/kmipcore/kmip_protocol.hpp

@@ -15,6 +15,7 @@
 #include <string>
 #include <utility>
 #include <vector>
+
 namespace kmipcore {
 
   /**
@@ -314,7 +315,6 @@ namespace kmipcore {
       nextBatchItemId_ = 1;
     }
 
-
     /** @brief Sets maximum response size hint in request header. */
     void setMaxResponseSize(size_t size);
     /** @brief Returns maximum response size hint from request header. */

kmipcore/include/kmipcore/kmip_requests.hpp

@@ -25,7 +25,6 @@ namespace kmipcore {
   // Construct one and pass it directly to RequestMessage::addBatchItem().
   // ---------------------------------------------------------------------------
 
-
   // ---------------------------------------------------------------------------
   // Template for simple requests that only carry a unique identifier.
   // ---------------------------------------------------------------------------
@@ -58,7 +57,6 @@ namespace kmipcore {
   /** @brief Typed request alias for KMIP Get Attribute List operation. */
   using GetAttributeListRequest = SimpleIdRequest<KMIP_OP_GET_ATTRIBUTE_LIST>;
 
-
   /** @brief Request for KMIP Get Attributes operation. */
   class GetAttributesRequest : public RequestBatchItem {
   public:
@@ -201,7 +199,6 @@ namespace kmipcore {
     );
   };
 
-
 }  // namespace kmipcore
 
 #endif /* KMIPCORE_KMIP_REQUESTS_HPP */

kmipcore/include/kmipcore/kmip_responses.hpp

@@ -299,7 +299,6 @@ namespace kmipcore {
     std::string clusterInfo_;
   };
 
-
 }  // namespace kmipcore
 
 #endif /* KMIPCORE_KMIP_RESPONSES_HPP */

kmipcore/src/kmip_basics.cpp

@@ -64,7 +64,6 @@ namespace kmipcore {
     }
   }
 
-
   void Element::serialize(SerializationBuffer &buf) const {
     // Write Tag (3 bytes, big-endian)
     const auto raw_tag = static_cast<std::uint32_t>(tag);

kmipcore/src/kmip_protocol.cpp

@@ -15,6 +15,7 @@
 #include <limits>
 #include <span>
 #include <vector>
+
 namespace kmipcore {
 
   namespace {
@@ -286,7 +287,6 @@ namespace kmipcore {
     }
   }
 
-
   void RequestMessage::setMaxResponseSize(size_t size) {
     if (size > static_cast<size_t>(std::numeric_limits<int32_t>::max())) {
       throw KmipException(

kmipcore/src/kmip_requests.cpp

@@ -861,5 +861,4 @@ namespace kmipcore {
     setRequestPayload(payload);
   }
 
-
 }  // namespace kmipcore